test(cypress): improve e2e test stability#2559
Merged
miaulalala merged 2 commits intomasterfrom May 6, 2026
Merged
Conversation
- toggleMenuAction: use force:true on clicks and a 10s timeout for the action element to survive Vue re-renders caused by async metadata updates (e.g. share badge appearing after file list load) - sidebar.cy.ts "Has share activity": wait for the files PROPFIND to complete after cy.visit so share DAV properties are fully applied before opening the Actions menu - settings.cy.ts "Form survive a reload": intercept and wait for the settings save API before each cy.reload(), matching the pattern already used by the other two tests in this suite - createPublicShare: remove duplicate intercept alias for the same POST endpoint and the redundant trailing cy.wait() - addTag: wait for the file row preview to load before triggering the action menu, consistent with renameFile AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Activity
 |
||||||||||||||||||||||||||||
| Project |
Activity
|
| Branch Review |
fix/cypress-stability
|
| Run status |
|
| Run duration | 02m 00s |
| Commit |
|
| Committer | Anna |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
 |
0
|
 |
0
|
 |
1
|
 |
0
|
 |
9
|
| View all changes introduced in this branch ↗︎ | |
Skip the re-navigation to /apps/files after createPublicShare.
The share is already recorded server-side (cy.wait('@createshare')) and
the sidebar is closed, so showActivityTab can be called directly.
Re-navigating caused NC to async-load the share badge on the file row,
which triggered a Vue re-render that closed the Actions menu before the
details entry could be clicked — failing even with a 10s timeout.
AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Anna Larch <anna@nextcloud.com>
mejo-
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
toggleMenuAction (
filesUtils.ts): add{ force: true }to both clicks and{ timeout: 10000 }on the action element lookup to survive Vue re-renders triggered by async metadata updates (e.g. share badge loading after file list render)."Has share activity" (
sidebar.cy.ts): remove thecy.visit('/apps/files')re-navigation aftercreatePublicShare. The share is already recorded server-side (waited on via@createShare) and the sidebar is already closed, soshowActivityTabcan be called directly. Re-navigating caused NC to async-load the share badge on the file row, which triggered a Vue re-render that closed the Actions menu before thedetailsentry could be clicked — failing even with a 10s timeout."Form survive a reload" (
settings.cy.ts): addcy.intercept+cy.wait('@apiCall')before eachcy.reload(), matching the pattern already used by the other two tests in this file.createPublicShare(sidebarUtils.ts): remove duplicate intercept alias for the same POST endpoint and the redundant trailingcy.wait('@createPublicShare').addTag(sidebarUtils.ts): wait for.files-list__row-icon-preview--loadedbefore opening the action menu, consistent withrenameFile.🤖 Generated with Claude Code