fix(NotificationGenerator): catch InvalidArgumentException from notification setters in prepare()#2604
Merged
miaulalala merged 1 commit intoMay 20, 2026
Conversation
Collaborator
Author
|
/backport to stable34 |
Activity
 |
||||||||||||||||||||||||||||||||||
| Project |
Activity
|
| Branch Review |
fix/nc39/notification-generator-invalid-argument-exception
|
| Run status |
|
| Run duration | 02m 17s |
| Commit |
|
| Committer | Anna |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
 |
1
|
 |
0
|
 |
1
|
 |
0
|
 |
8
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
| Test | Artifacts | |
|---|---|---|
| Check that user's settings survive a reload > Form survive a reload |
Test Replay
Screenshots
|
|
nickvergessen
approved these changes
May 20, 2026
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Reviewed the second commit. First one seems to be another PR
miaulalala
force-pushed
the
fix/nc39/notification-generator-invalid-argument-exception
branch
from
17a425e to
dbe268a
Compare
…ication setters in prepare() INotification setters like setRichSubject() and setParsedSubject() throw \InvalidArgumentException for empty/invalid values, which previously escaped prepare() — triggering the NC39 deprecation. Catch and discard the notification as already-processed since it cannot be rendered. AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com>
miaulalala
force-pushed
the
fix/nc39/notification-generator-invalid-argument-exception
branch
from
dbe268a to
2c05121
Compare
miaulalala
deleted the
fix/nc39/notification-generator-invalid-argument-exception
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
INotificationsetters (setRichSubject(),setParsedSubject()) throw\InvalidArgumentExceptionfor empty/invalid valuesprepare(), triggering the NC39 deprecation: "threw \InvalidArgumentException which is deprecated"AlreadyProcessedExceptionto discard the unrenderable notificationTest plan
composer test:unit\InvalidArgumentExceptionescapesprepare()in the activity notifier logs🤖 Generated with Claude Code