feat(theming): Optional icon coloring for navigationView (#64), support for rounded corners (#66) #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt for rounded corners (#66)
stefan-niedermann
requested review from
AlvaroBrey,
AndyScherzinger and
tobiasKaminsky
This was
linked to
issues
Feb 11, 2023
AndyScherzinger
approved these changes
Feb 14, 2023
Member
AndyScherzinger
left a comment
AndyScherzinger
left a comment
There was a problem hiding this comment.
fine by me, let's give it a try I would say.
AlvaroBrey
requested changes
Feb 16, 2023
ui/src/main/java/com/nextcloud/android/common/ui/theme/utils/AndroidViewThemeUtils.kt
Show resolved
Hide resolved
…Utils Preserves compatibility with Java clients Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
AlvaroBrey
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optional icon coloring (#64)
The API was changed non breaking by adding an additional optional argument to skip icon coloring.
Support for rounded corners (#66)
I am not entirely sure about this one to be honest. After the code changes I could not see any difference to the previous implementation except support for rounded corners.
Would love some feedback and review for this one especially 🙂