Skip to content

add: windows compatible filenames capability #1870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2025
+13 −0
Merged

add: windows compatible filenames capability #1870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7496008
add: windows compatible filenames capability
alperozturk96 Oct 21, 2025
d269978
solve git conflict
alperozturk96 Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions library/src/androidTest/java/com/owncloud/android/GetCapabilitiesRemoteOperationIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,5 +157,10 @@ private void checkCapability(OCCapability capability, String userId) {

// support
assertTrue(capability.getHasValidSubscription().isFalse());

// wcf
if (capability.getVersion().isNewerOrEqual(NextcloudVersion.nextcloud_32)) {
Copy link
Contributor Author

@alperozturk96 alperozturk96 Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New flag only available after nextcloud_32

assertTrue(capability.isWCFEnabled().isFalse());
}
}
}
7 changes: 7 additions & 0 deletions ...c/main/java/com/owncloud/android/lib/resources/status/GetCapabilitiesRemoteOperation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,8 @@ public class GetCapabilitiesRemoteOperation extends RemoteOperation {
private static final String FORBIDDEN_FILENAME_EXTENSIONS = "forbidden_filename_extensions";
private static final String FORBIDDEN_FILENAME_BASE_NAMES = "forbidden_filename_basenames";

private static final String WINDOWS_COMPATIBLE_FILENAMES = "windows_compatible_filenames";

// files download limits
private static final String NODE_FILES_DOWNLOAD_LIMIT = "downloadlimit";
private static final String FILES_DOWNLOAD_LIMIT_DEFAULT = "default-limit";
Expand Down Expand Up @@ -486,6 +488,11 @@ private OCCapability parseResponse(String response) throws JSONException {
JSONArray result = respFiles.getJSONArray(FORBIDDEN_FILENAME_BASE_NAMES);
capability.setForbiddenFilenameBaseNamesJson(result.toString());
}

if (respFiles.has(WINDOWS_COMPATIBLE_FILENAMES)) {
capability.setWCFEnabled(CapabilityBooleanType.fromBooleanValue(
respFiles.getBoolean(WINDOWS_COMPATIBLE_FILENAMES)));
}
// endregion

Log_OC.d(TAG, "*** Added " + NODE_FILES);
Expand Down
1 change: 1 addition & 0 deletions library/src/main/java/com/owncloud/android/lib/resources/status/OCCapability.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ class OCCapability {
var forbiddenFilenamesJson: String? = null
var forbiddenFilenameExtensionJson: String? = null
var forbiddenFilenameBaseNamesJson: String? = null
var isWCFEnabled = CapabilityBooleanType.UNKNOWN

// files download limits
var filesDownloadLimit = CapabilityBooleanType.UNKNOWN
Expand Down
Loading