feat(e2ee): add deletion functions#2000
Merged
alperozturk96 merged 4 commits intomasterfrom May 4, 2026
Merged
Conversation
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Contributor
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Contributor
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
|
|
||
| class DeleteE2ERemoteOperationIT : AbstractIT() { | ||
| @Test | ||
| fun testDeleteEncryptedFiles() { |
Member
There was a problem hiding this comment.
Those tests will also return success if there is no key/file at all, right?
I guess it is hard to test it within library, but then we should test it within client:
- set up everything
- doing existing e2e tests
- remove files and keys
- verify that they are not there, via get private/public key
tobiasKaminsky
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
App PR: nextcloud/android#16926