screenshottest are error prone

[hannesa2]

As every pull request is failing I observed that this gradle task genericDebugExecuteScreenshotTests is complete missing in tasks.

Why not remove screenShotTest.yml complete ?

https://github.com/nextcloud/android/actions/runs/27017487150/job/79736253318?pr=17139

/usr/bin/sh -c ./gradlew uninstallAll genericDebugExecuteScreenshotTests -Dorg.gradle.jvmargs="--add-opens java.base/java.nio=ALL-UNNAMED --add-opens java.base/java.nio.channels=ALL-UNNAMED --add-exports java.base/sun.nio.ch=ALL-UNNAMED" -Pandroid.testInstrumentationRunnerArguments.annotation=com.owncloud.android.utils.ScreenshotTest -Pandroid.testInstrumentationRunnerArguments.COLOR=blue -Pandroid.testInstrumentationRunnerArguments.DARKMODE=Light
INFO         | Boot completed in 18719 ms
INFO         | Increasing screen off timeout, logcat buffer size to 2M.
Starting a Gradle Daemon, 1 incompatible Daemon could not be reused, use --status for details
Configuration on demand is an incubating feature.
Calculating task graph as no cached configuration is available for tasks: uninstallAll genericDebugExecuteScreenshotTests

> Configure project :app
Gradle uses Java 21.0.11 (Eclipse Adoptium 21.0.11+10-LTS)

[Incubating] Problems report is available at: file:///home/runner/work/android/android/build/reports/problems/problems-report.html

FAILURE: Build failed with an exception.

* What went wrong:
Task 'genericDebugExecuteScreenshotTests' not found in root project 'Nextcloud' and its subprojects.

[PhilLab]

Note: the title might be a bit misleading for some, because for many many months, the screenshot tests did run but were failing due to stability issues which were never addressed.

What @hannesa2 is reporting here is a new failure cause, that is that the gradle task somehow has disappeared completely. So the task must be reinstated and then the stability issues be fixed.

[hannesa2]

Yes, I suspected as much, but right now it's simply broken and makes every pull request faulty.

What's about to get rid of it complete and (maybe at the same time) make a new pull request to re-introduce screenshot compare again. There the stability can be fixed separately.

@PhilLab which pull request removed the screenshot tests many many months ago ?

[PhilLab]

which pull request removed the screenshot tests many many months ago ?

this is not what I was trying to say. I said: for many many months, the screenshot tests were there, did run, but always failed.

Later, at a time unknown to me, apparently the gradle task got removed, leading to your observation. I assume that this removal was not intentional. We should find out which PR caused this.