Re-think account migration trigger

[ezaquarii]

I found that we're triggering account upgrade in FileActivity.onCreate(). I'm not sure if this is the best place to do it.

What was the motivation to perform it here? Would it be better to handle thin in MainApp?

51d7ea8#r33162648

[tobiasKaminsky]

While thinking about it, I think it is best to have it in MainApp as you suggest.
We can also do it smarter:
As this is only for old accounts, we can disable this once we know that every account was migrated.

As I already work on account migration, I can tackle this.

[ezaquarii]

IMO MainApp.preAttach() guarantees that the migration will be triggered on app startup before anything else (like service or broadcast receiver start).

Do you have visibility into how many clients are there that trigger this code path? It might be worth discussing with the stakeholders to ask the users to just login again and perform a full re-sync instead, especially if nobody actually test this code.

It's a business decision, so I can't recommend anything of real value here.

Do or do not, there is no try.

-- Master Yoda.

[mario]

@ezaquarii unfortunately (or luckily?) not because we don't do any tracking.

And it could easily be moved to the MainApp but I just wanted to avoid the "delay" in starting the app, which, while not significant enough, adds up.

[ezaquarii]

I think we could try to do it by placing #3885 in the onboarding department #4042

Whenever a breaking data model change happens, launch "what's new activity" that blocks the UI until all data is migrated successfully, possibly reminding the user how hard Nextcloud team works to "add value". <-:[

In case the migration didn't go well or - perhaps - is simply too complex to implement in the first place it tells the user that a full re-sync is required to proceed.

[AndyScherzinger]

That sound good to me and we could even add some nice animation or whatsoever at some point :)