Translation error (german)

[stefan-niedermann]

cc @rakekniven - sorry, didn't know how to properly notify you...

In the Nextcloud Android app click on the +-button.

"Neu erstellen Textdokument" looks wrong. Either

• "Neu erstellen: Textdokument" or
• "Neues Textdokument erstellen"

[rakekniven]

Hello @stefan-niedermann ,

no problems to mention me at GitHub.

Just did a quick search and have not been able to find given string at Transifex ...

Which version are you using? latest greatest?

Cheers

[stefan-niedermann]

3.14.1, i think it's the latest released version an F-Droid.

Maybe it's a concatenated string? ("Textdokument" could be a parameter)

[AndyScherzinger]

it is concatenated:

OCFileListBottomSheetDialog.java line ~114 ff.

creatorViewBinding.creatorName.setText(
                        String.format(fileActivity.getString(R.string.editor_placeholder),
                                      fileActivity.getString(R.string.create_new),
                                      creator.getName()));

with editor placeholder being

%1$s %2$s

So you can't you anything about this, looping in @tobiasKaminsky I think we could fix this be rather using a string with a single placeholder for the document type being created by the respective menu item so order of words can be language depended and be handled by the translator :)

So should be doable, but needs a code change

[rakekniven]

Concatenated strings are evil 👿

[stefan-niedermann]

Or just a colon : before the type of the document?

[AndyScherzinger]

Or just a colon : before the type of the document?

Nope that'll probably won't work for R-T-L languages

[AndyScherzinger]

... I guess

[stefan-niedermann]

Why not? the default string could be %1$s: %2$s and a translation of a R-T-L language can be %2$s :%1$s - though i think the browser Android should handle that still correctly 🤷‍♂️

[AndyScherzinger]

ah, well %1$s %2$s is currently flagged as translatable=false which kind of makes sense this a pure placeholder file is impossible to translate with a description of the actual usage scenario :/ I still think a string with one placeholder solves the problem just fine and is easy to understand for the translators.

[tobiasKaminsky]

I think both approaches work, but having there a colon, when we have it nowhere else feels a bit off

(just for showing how it is handled with other filetypes)

So I would go with Andy's idea.
Please use new string names, as otherwise it will create trouble with non-updated languages.

[rakekniven]

We have many many strings at Transifex like "Create new folder", "Create new foobar". Without using any placeholder.

Using more than one should be avoided for such strings.

Jm2c.

[AndyScherzinger]

Using more than one should be avoided for such strings.

Create new %1s

@rakekniven how do you deal with the thing in @tobiasKaminsky's screenshot e.g. table and document since:

English:

• create new table
• create new document

German

• Neue Tabelle erstellen
• Neues Dokument erstellen

So a placeholder won't work and I can't say if this is even more complex in other languages...

[rakekniven]

Oh, forgot to edit my previous posting. Same thought as yours (👍 ) came to my mind.
Please do not use any placeholder at all. Make single strings for each

• Create new document
• Create new spreadsheet
• Create new presentation
• ...