Skip to content

i18n: Change name of encryption#11097

Merged
AlvaroBrey merged 4 commits intomasterfrom
Valdnet-patch-1
Nov 28, 2022
Merged

i18n: Change name of encryption#11097
AlvaroBrey merged 4 commits intomasterfrom
Valdnet-patch-1

Conversation

@Valdnet
Copy link
Copy Markdown
Contributor

@Valdnet Valdnet commented Nov 26, 2022

Signed-off-by: Valdnet 47037905+Valdnet@users.noreply.github.com

  • Tests written, or not not needed

@Valdnet Valdnet added the i18n label Nov 26, 2022
@Valdnet Valdnet self-assigned this Nov 26, 2022
Copy link
Copy Markdown
Member

@rakekniven rakekniven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Valdnet Valdnet requested a review from rakekniven November 27, 2022 20:14
@Valdnet
Copy link
Copy Markdown
Contributor Author

Valdnet commented Nov 27, 2022

Corrected 😉.

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 27, 2022

Codecov Report

Merging #11097 (7e003a9) into master (a489619) will increase coverage by 27.52%.
The diff coverage is n/a.

❗ Current head 7e003a9 differs from pull request most recent head d184aa6. Consider uploading reports for the commit d184aa6 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #11097       +/-   ##
=============================================
+ Coverage      3.19%   30.71%   +27.52%     
- Complexity      420     3265     +2845     
=============================================
  Files           564      564               
  Lines         41616    41616               
  Branches       5657     5657               
=============================================
+ Hits           1330    12783    +11453     
+ Misses        40203    26909    -13294     
- Partials         83     1924     +1841     
Impacted Files Coverage Δ
.../third_parties/daveKoeller/AlphanumComparator.java 86.90% <0.00%> (-1.20%) ⬇️
.../java/com/owncloud/android/datamodel/GalleryRow.kt 50.00% <0.00%> (ø)
...roid/ui/activity/ReceiveExternalFilesActivity.java 0.35% <0.00%> (+0.35%) ⬆️
...owncloud/android/ui/activity/PassCodeActivity.java 0.51% <0.00%> (+0.51%) ⬆️
...cloud/android/ui/preview/PreviewImageActivity.java 0.55% <0.00%> (+0.55%) ⬆️
...owncloud/android/ui/activity/UserInfoActivity.java 0.58% <0.00%> (+0.58%) ⬆️
...oud/android/ui/activity/NotificationsActivity.java 0.59% <0.00%> (+0.59%) ⬆️
...tcloud/client/database/migrations/RoomMigration.kt 0.66% <0.00%> (+0.66%) ⬆️
...ui/fragment/contactsbackup/BackupListFragment.java 0.94% <0.00%> (+0.94%) ⬆️
...loud/android/ui/activities/ActivitiesActivity.java 1.03% <0.00%> (+1.03%) ⬆️
... and 280 more

@Valdnet Valdnet mentioned this pull request Nov 27, 2022
1 task
@github-actions
Copy link
Copy Markdown

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
@AndyScherzinger
Copy link
Copy Markdown
Member

/backport to stable-3.23

@AndyScherzinger
Copy link
Copy Markdown
Member

/backport to stable-3.22

@github-actions
Copy link
Copy Markdown

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11097.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link
Copy Markdown

Codacy

Lint

TypemasterPR
Warnings8282
Errors00

SpotBugs

CategoryBaseNew
Bad practice2727
Correctness4545
Dodgy code336336
Internationalization99
Multithreaded correctness99
Performance5858
Security1818
Total502502

@github-actions
Copy link
Copy Markdown

@AlvaroBrey AlvaroBrey merged commit 725348a into master Nov 28, 2022
@delete-merged-branch delete-merged-branch Bot deleted the Valdnet-patch-1 branch November 28, 2022 11:53
@AlvaroBrey AlvaroBrey added this to the Nextcloud App 3.24.0 milestone Nov 28, 2022
@AlvaroBrey
Copy link
Copy Markdown
Member

Thanks @Valdnet !

@backportbot-nextcloud
Copy link
Copy Markdown

The backport to stable-3.23 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link
Copy Markdown

The backport to stable-3.22 failed. Please do this backport manually.

@AlvaroBrey
Copy link
Copy Markdown
Member

Backports are not actually needed, as the PR that introduced these strings was not backported to 3.22 or 3.23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants