Retain search

[mario]

Signed-off-by: Mario Danic mario@lovelyhq.com

Fixes #686
Fixes #2243

[mario]

@AndyScherzinger @tobiasKaminsky pls fix codacy when one of you gets to this PR :)

[tobiasKaminsky]

@mario not working for me :-/

Entered search term "about" and search:

open up text file

Then pressing back or "arrow left" results in

There needs to be the search query "about" so that

• is visible to the user that search results are presented
• the search can be dismissed
  • as right now a click back closes the app
  • to get the file list back you have to open up the drawer and select "all files"

[mario]

@tobiasKaminsky I used EXACTLY this workflow and it worked. Will test again in a bit.

[AndyScherzinger]

haven't tested it yet but just fixed codacy (+rebase)

[mario]

I will try to fix this tonight before leaving.

[mario]

So I've made some progress on this. However, it requires some changes to the overall structure of the app in the fact that all these previews should not inherit from FileDisplayActivity, but should instead have their own activity. Once this is done, the search will be trivial.

Postponing this to currently 1.5.1 (or 2.0.1, whatever).

[AndyScherzinger]

Thanks for the update @mario :)

@tobiasKaminsky I'd also then vote for postponing this issue/pr for the next bugfix release.

[mario]

@AndyScherzinger if any of you can do this (separating previews to their own activity) while I'm away, that would be cool! :)

[AndyScherzinger]

I am blocked for the rest of the week unfortunately and am hoping that we can release an RC to GPlay soon... Really hope to get that done so we can gain some more user feedback.

@tobiasKaminsky are you able to build beta releases for GPlay?

[mario]

@AndyScherzinger I can build a release still for the next few days so no worries. We have changelog + events refactor + those lint fixes to merge by @tobiasKaminsky and let's do it! :)

I was kindly asking if you can do it in the next few weeks so I can fix search after that :)

[mario]

Oh and the new screen!

[AndyScherzinger]

Ah okay :) weeks sounds way better then the next days :)

[nextcloud-android-bot]

Lint

Type	Master	PR
Warnings	113	113
Errors

FindBugs (new)

Warning Type	Number
Bad practice Warnings	35
Correctness Warnings	167
Internationalization Warnings	14
Malicious code vulnerability Warnings	10
Multithreaded correctness Warnings	9
Performance Warnings	124
Security Warnings	202
Dodgy code Warnings	139
Total	700

FindBugs (master)

Warning Type	Number
Bad practice Warnings	35
Correctness Warnings	167
Internationalization Warnings	14
Malicious code vulnerability Warnings	10
Multithreaded correctness Warnings	9
Performance Warnings	124
Security Warnings	202
Dodgy code Warnings	139
Total	700

[tobiasKaminsky]

Closing this one as it is rather old.
If we want to fix this, we can still re-open.