Skip to content

BugFix - Observe Download State In Encrypted Folder#14485

Merged
tobiasKaminsky merged 2 commits intomasterfrom
bugfix/observe-download-state
Feb 10, 2025
Merged

BugFix - Observe Download State In Encrypted Folder#14485
tobiasKaminsky merged 2 commits intomasterfrom
bugfix/observe-download-state

Conversation

@alperozturk96
Copy link
Copy Markdown
Collaborator

@alperozturk96 alperozturk96 commented Feb 3, 2025

  • Tests written, or not not needed

Before

before.mp4

After

after.mp4

Known Issue

#14484

@alperozturk96 alperozturk96 changed the title BugFix - Observe Download State BugFix - Observe Download State In Encrypted Folder Feb 3, 2025
@alperozturk96 alperozturk96 requested a review from ZetaTom February 3, 2025 09:41
@alperozturk96
Copy link
Copy Markdown
Collaborator Author

Link increased due to:
Screenshot 2025-02-03 at 10 55 13

But I didn't touch that file. @tobiasKaminsky

Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the bugfix/observe-download-state branch from 75547de to b4e6a5c Compare February 5, 2025 13:08
fragment = FileDownloadFragment.newInstance(file, user, true, i)
(fragment as FileDownloadFragment).setError(true)
} else {
fragment = if (file.isEncrypted) {
Copy link
Copy Markdown
Collaborator Author

@alperozturk96 alperozturk96 Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tobiasKaminsky If I don't use FileDownloadFragment, this happens:

kee.mp4

So better to keep it.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 5, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14485.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 5, 2025

Codacy

Lint

TypemasterPR
Warnings5556
Errors33

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness5757
Dodgy code294294
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness77
Performance5353
Security1818
Total503503

Lint increased!

@alperozturk96 alperozturk96 added this to the Nextcloud App 3.31.0 milestone Feb 10, 2025
@alperozturk96
Copy link
Copy Markdown
Collaborator Author

/backport to stable-3.31

@tobiasKaminsky tobiasKaminsky merged commit de0a88d into master Feb 10, 2025
19 of 21 checks passed
@tobiasKaminsky tobiasKaminsky deleted the bugfix/observe-download-state branch February 10, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants