Skip to content

Fix deprecated github action and simplify CI#14562

Merged
AndyScherzinger merged 2 commits intomasterfrom
DeprecatedGithubAction
Mar 9, 2025
Merged

Fix deprecated github action and simplify CI#14562
AndyScherzinger merged 2 commits intomasterfrom
DeprecatedGithubAction

Conversation

@hannesa2
Copy link
Copy Markdown
Contributor

I observe this
image

in https://github.com/nextcloud/android/actions/runs/13406222141/job/37446516311

Solving this, I merged at least two CI files to shrink the job list a little bit in https://github.com/nextcloud/android/actions and remove boiler plate code in github actions

@hannesa2
Copy link
Copy Markdown
Contributor Author

What's that ?
image

@tobiasKaminsky

@hannesa2 hannesa2 force-pushed the DeprecatedGithubAction branch from 05ef68e to fff1043 Compare February 19, 2025 06:03
@hannesa2
Copy link
Copy Markdown
Contributor Author

Next issue: Drone still using .github/workflows/gradle-wrapper-validation.yml but PR removed it.
https://drone.nextcloud.com/nextcloud/android/18784
image

@AndyScherzinger AndyScherzinger added 3. to review ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Feb 20, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 6, 2025

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@AndyScherzinger
Copy link
Copy Markdown
Member

@hannesa2 regarding #14562 (comment)

Next issue: Drone still using .github/workflows/gradle-wrapper-validation.yml but PR removed it.

Your screenshot clearly states "delete mode" in the last log line. So I think this is correct, no?

@hannesa2
Copy link
Copy Markdown
Contributor Author

hannesa2 commented Mar 9, 2025

No clue what the question is. I deleted the action, move it to existing job and modernized it

@AndyScherzinger
Copy link
Copy Markdown
Member

The question was about #14562 (comment) where you said that drone is still picking up the action (which is a GH action) and posted the screenshot while that drone console output is just the git statement that that file has been deleted. So my question is if your statement there while looking at the screenshot is a false interpretation of the console output.

@hannesa2
Copy link
Copy Markdown
Contributor Author

hannesa2 commented Mar 9, 2025

I've no clue about deeper drone functionality.
Please look at the changes tab, it explain everything about this minor change !
Any more conversation doesn't make this small changes simpler

Signed-off-by: Hannes Achleitner <hannes.software@gmx.at>
@AndyScherzinger AndyScherzinger force-pushed the DeprecatedGithubAction branch from 5ab2ec3 to 5656e67 Compare March 9, 2025 18:49
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 9, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14562.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Copy link
Copy Markdown
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, Updated the used action definition to use the commit sha for pinning, updates will be handled by renovate bot automatically.

@AndyScherzinger AndyScherzinger merged commit 6f0350c into master Mar 9, 2025
@AndyScherzinger AndyScherzinger deleted the DeprecatedGithubAction branch March 9, 2025 19:11
@AndyScherzinger
Copy link
Copy Markdown
Member

Nice cleanup @hannesa2 rebased, run and merged 👍

@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.32.0 milestone Mar 9, 2025
AndyScherzinger added a commit to nextcloud/android-config that referenced this pull request Mar 10, 2025
Obsolete check to be included in the assemble CI actions, see nextcloud/android#14562 for details

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review feedback-requested ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants