Feature - Add Custom Share Permissions #14729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alperozturk96
changed the title
alperozturk96
commented
Mar 27, 2025
| /** | ||
| * get the permissions on the basis of selection | ||
| */ | ||
| private fun getSelectedPermission() = when { |
Collaborator
Author
There was a problem hiding this comment.
No need this function anymore. clickEvents assigns value for the permission
alperozturk96
force-pushed
the
feature/add-share-permissions
branch
from
cbf504a to
c27d9ee
Compare
alperozturk96
force-pushed
the
feature/add-share-permissions
branch
2 times, most recently
from
bf9eb82 to
5eae6b1
Compare
alperozturk96
commented
Apr 1, 2025
Comment on lines
-40
to
-87
| /** | ||
| * Sets checked/visibility state on the given {@link MenuItem} based on the given criteria. | ||
| * | ||
| * @param menuItem the {@link MenuItem} to be setup | ||
| */ | ||
| public static void setupHideFileDownload(MenuItem menuItem, | ||
| boolean hideFileDownload, | ||
| boolean isFileDrop) { | ||
| if (isFileDrop) { | ||
| menuItem.setVisible(false); | ||
| } else { | ||
| menuItem.setVisible(true); | ||
| menuItem.setChecked(hideFileDownload); | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * sets up the password {@link MenuItem}'s title based on the fact if a password is present. | ||
| * | ||
| * @param password the password {@link MenuItem} | ||
| * @param isPasswordProtected flag is a password is present | ||
| */ | ||
| public static void setupPasswordMenuItem(MenuItem password, boolean isPasswordProtected) { | ||
| if (isPasswordProtected) { | ||
| password.setTitle(R.string.share_password_title); | ||
| } else { | ||
| password.setTitle(R.string.share_no_password_title); | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * sets up the expiration date {@link MenuItem}'s title based on the fact if an expiration date is present. | ||
| * | ||
| * @param expirationDate the expiration date {@link MenuItem} | ||
| * @param expirationDateValue the expiration date | ||
| * @param res Resources to load the corresponding strings. | ||
| */ | ||
| public static void setupExpirationDateMenuItem(MenuItem expirationDate, long expirationDateValue, Resources res) { | ||
| if (expirationDateValue > 0) { | ||
| expirationDate.setTitle(res.getString( | ||
| R.string.share_expiration_date_label, | ||
| SimpleDateFormat.getDateInstance().format(new Date(expirationDateValue)) | ||
| )); | ||
| } else { | ||
| expirationDate.setTitle(R.string.share_no_expiration_date_label); | ||
| } | ||
| } | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
Unused functions
alperozturk96
force-pushed
the
feature/add-share-permissions
branch
from
3fcc813 to
1b1bc00
Compare
alperozturk96
force-pushed
the
feature/add-share-permissions
branch
2 times, most recently
from
f1196f6 to
2aaa34d
Compare
alperozturk96
force-pushed
the
feature/add-share-permissions
branch
from
12beb86 to
735ee0b
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
alperozturk96
force-pushed
the
feature/add-share-permissions
branch
from
a789b30 to
43fd840
Compare
alperozturk96
force-pushed
the
feature/add-share-permissions
branch
2 times, most recently
from
4328310 to
a5a560a
Compare
This was referenced May 5, 2025
This comment was marked as resolved.
This comment was marked as resolved.
alperozturk96
force-pushed
the
feature/add-share-permissions
branch
2 times, most recently
from
2dcf77e to
63df1a9
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
alperozturk96
force-pushed
the
feature/add-share-permissions
branch
from
f9a902f to
6e5ade0
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14729.apk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Library PR: nextcloud/android-library#1706