Fix Image Loading When Offline

[alexknop]

Problem:

Although Videos were loading immediately when offline, Images were not

Solution:
Found that checking for whether file is offline was passing, but the ! in the code was making it false, forcing a sync which would timeout (taking extra time) and preventing immediate access to images

Fixes #14470

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[tobiasKaminsky]

Thanks for the fix.
Please see #14470 (comment)

I cannot reproduce it on master, thus I cannot test the fix.

[alexknop]

Thanks for the fix. Please see #14470 (comment)

I cannot reproduce it on master, thus I cannot test the fix.

Check #14470 (comment) where displaying the video is working fine but then I try to select an image after and it won't load.
However looking at my proposed changes, don't we want to properly check if the image is downloaded before passing to the startImagePreview() function?

[tobiasKaminsky]

👍 You are right.
I mixed things up.

I will rebase, so that CI runs again.

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	51	51
Errors	11	11

SpotBugs

Category	Base	New
Bad practice	65	65
Correctness	58	59
Dodgy code	292	279
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	1	1
Multithreaded correctness	7	7
Performance	51	48
Security	18	18
Total	500	485

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14733.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.