Skip to content

Conversation

@alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Apr 8, 2025

  • Tests written, or not not needed

Try to open .xlsx file, it should redirect to an app that can view .xlsx file.

… available

Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the handle-downloaded-file-open-intent branch from bbd64e6 to ded458e Compare April 22, 2025 12:38
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@github-actions
Copy link

Codacy

Lint

TypemasterPR
Warnings5451
Errors1111

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness5859
Dodgy code292279
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness77
Performance5147
Security1818
Total500484

@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14775.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@codecov
Copy link

codecov bot commented Apr 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 56 lines in your changes missing coverage. Please review.

Project coverage is 24.48%. Comparing base (dbb3551) to head (01f3088).
Report is 102 commits behind head on master.

Files with missing lines Patch % Lines
...cloud/android/ui/helpers/FileOperationsHelper.java 0.00% 55 Missing ⚠️
...in/java/com/owncloud/android/datamodel/OCFile.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14775      +/-   ##
============================================
+ Coverage     24.17%   24.48%   +0.30%     
- Complexity     3327     3405      +78     
============================================
  Files           706      706              
  Lines         51400    52157     +757     
  Branches       6881     7074     +193     
============================================
+ Hits          12428    12769     +341     
- Misses        36988    37375     +387     
- Partials       1984     2013      +29     
Files with missing lines Coverage Δ
...in/java/com/owncloud/android/datamodel/OCFile.java 81.29% <0.00%> (+0.96%) ⬆️
...cloud/android/ui/helpers/FileOperationsHelper.java 3.95% <0.00%> (+0.01%) ⬆️

... and 23 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tobiasKaminsky
Copy link
Member

Smoke test

  • download xls/office files
  • download other file types

@tobiasKaminsky
Copy link
Member

/backport to stable-3.31

@tobiasKaminsky tobiasKaminsky merged commit 20809a4 into master May 12, 2025
21 of 22 checks passed
@tobiasKaminsky tobiasKaminsky deleted the handle-downloaded-file-open-intent branch May 12, 2025 06:18
@tobiasKaminsky tobiasKaminsky added this to the Nextcloud App 3.32.0 milestone May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants