-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Improve File Download Tracking #14857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| fda.previewAndHandleImageFile(file, searchFragment, currentSearchType); | ||
| } else if (file.isDown() && mContainerActivity instanceof FileDisplayActivity fda) { | ||
| fda.previewDownloadedFile(file, this::setFabVisible); | ||
| } else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This entire preview logic belongs in FileDisplayActivity and needs to be accessible from there as well,
because after the file download is completed, the fragment is no longer an instance of OCFileListFragment,
so this function cannot be used from FileDisplayActivity.
f188333 to
70ec2a7
Compare
app/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.java
Outdated
Show resolved
Hide resolved
27fddc1 to
5dd26fb
Compare
5004af8 to
0b5955a
Compare
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
0b5955a to
bc92642
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14857.apk |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14857 +/- ##
=============================================
+ Coverage 0 23.11% +23.11%
- Complexity 0 3223 +3223
=============================================
Files 0 712 +712
Lines 0 51713 +51713
Branches 0 6969 +6969
=============================================
+ Hits 0 11955 +11955
- Misses 0 37879 +37879
- Partials 0 1879 +1879
🚀 New features to boost your workflow:
|
|
/backport to stable-3.32 |
|
/backport to stable-3.32 |

Resolves: #14850
Tested with XLSX and PDF files
Downloading Small PDF
Screen.Recording.2025-05-02.at.15.55.14.mp4
Downloading Large PDF
ddd.mp4
Optional: Showing FileDetailFragment Based on Download Speed:
While 1MB may be considered small under typical internet speeds, it can take several minutes to download for users with slower connections. In such cases, displaying the FileDetailFragment instead of skipping it might be more meaningful. We could potentially detect the user's download speed and, if the estimated download time exceeds 5 seconds, show the FileDetailFragment. However, this may be a feature to consider in the future.