Skip to content

Conversation

@alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Jun 12, 2025

  • Tests written, or not not needed

Min supported Android API Level is 26
Uses NC Android lib 2.21.0 RC1
OUTDATED_SERVER_VERSION is 29

@alperozturk96 alperozturk96 added this to the Nextcloud App 3.32.0 milestone Jun 12, 2025
@alperozturk96 alperozturk96 force-pushed the drop-min-supported-versions branch 2 times, most recently from a5c9ceb to 60382a3 Compare June 12, 2025 09:50
@alperozturk96

This comment was marked as resolved.

@alperozturk96

This comment was marked as resolved.

@alperozturk96 alperozturk96 requested a review from ZetaTom June 12, 2025 10:12
@tobiasKaminsky

This comment was marked as resolved.

@tobiasKaminsky

This comment was marked as resolved.

@alperozturk96

This comment was marked as resolved.

@alperozturk96

This comment was marked as resolved.

@nextcloud nextcloud deleted a comment from github-actions bot Jun 12, 2025
@nextcloud nextcloud deleted a comment from github-actions bot Jun 12, 2025
@codecov
Copy link

codecov bot commented Jun 12, 2025

Codecov Report

Attention: Patch coverage is 9.37500% with 29 lines in your changes missing coverage. Please review.

Project coverage is 23.22%. Comparing base (50eb848) to head (23a69a0).

Files with missing lines Patch % Lines
...va/com/nextcloud/client/media/AudioFocusManager.kt 0.00% 15 Missing ⚠️
...ird_parties/ezvcard_android/ContactOperations.java 0.00% 6 Missing ⚠️
...pp/src/main/java/com/owncloud/android/MainApp.java 33.33% 0 Missing and 2 partials ⚠️
...om/nextcloud/client/editimage/EditImageActivity.kt 0.00% 1 Missing ⚠️
...n/java/com/nextcloud/client/media/PlayerService.kt 0.00% 1 Missing ⚠️
.../nextcloud/client/media/PlayerServiceConnection.kt 0.00% 1 Missing ⚠️
.../owncloud/android/syncadapter/FileSyncAdapter.java 0.00% 1 Missing ⚠️
...ncloud/android/ui/asynctasks/LoadContactsTask.java 0.00% 1 Missing ⚠️
...d/ui/fragment/FileDetailsSharingProcessFragment.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             master   #14994       +/-   ##
=============================================
+ Coverage          0   23.22%   +23.22%     
- Complexity        0     3233     +3233     
=============================================
  Files             0      710      +710     
  Lines             0    51644    +51644     
  Branches          0     6908     +6908     
=============================================
+ Hits              0    11994    +11994     
- Misses            0    37767    +37767     
- Partials          0     1883     +1883     
Files with missing lines Coverage Δ
...nextcloud/client/jobs/MediaFoldersDetectionWork.kt 19.35% <ø> (ø)
...ent/jobs/notification/WorkerNotificationManager.kt 74.28% <100.00%> (ø)
...client/notifications/AppNotificationManagerImpl.kt 42.10% <100.00%> (ø)
...ud/android/operations/GetSharesForFileOperation.kt 50.00% <ø> (ø)
...main/java/com/owncloud/android/utils/FileUtil.java 69.23% <ø> (ø)
...om/nextcloud/client/editimage/EditImageActivity.kt 0.00% <0.00%> (ø)
...n/java/com/nextcloud/client/media/PlayerService.kt 0.00% <0.00%> (ø)
.../nextcloud/client/media/PlayerServiceConnection.kt 3.63% <0.00%> (ø)
.../owncloud/android/syncadapter/FileSyncAdapter.java 4.34% <0.00%> (ø)
...ncloud/android/ui/asynctasks/LoadContactsTask.java 0.00% <0.00%> (ø)
... and 4 more

... and 696 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

alperozturk96 and others added 8 commits June 16, 2025 11:11
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@tobiasKaminsky tobiasKaminsky force-pushed the drop-min-supported-versions branch from 23a69a0 to df2a961 Compare June 16, 2025 09:12
@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14994.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link

Codacy

Lint

TypemasterPR
Warnings5151
Errors1111

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness5862
Dodgy code292270
Experimental11
Internationalization77
Malicious code vulnerability12
Multithreaded correctness77
Performance5148
Security1818
Total500480

@alperozturk96 alperozturk96 merged commit b1198a8 into master Jun 16, 2025
21 of 27 checks passed
@alperozturk96 alperozturk96 deleted the drop-min-supported-versions branch June 16, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants