BugFix - Do Not Apply HideBottomViewOnScrollBehavior For Bottom Navigation View #15037
Conversation
| android:layout_gravity="center_horizontal" | ||
| android:gravity="center_horizontal" | ||
| android:orientation="vertical" | ||
| android:layout_marginBottom="@dimen/standard_double_margin" |
There was a problem hiding this comment.
Footer and last item in the list must be visible, thus bottom margin needed.
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
| val binding = ListFooterBinding.inflate(inflater, parent, false) | ||
| OCFileListFooterViewHolder(binding) | ||
| } | ||
| else -> throw IllegalArgumentException("Unsupported view type: $viewType") |
There was a problem hiding this comment.
The value must be one of the following: VIEW_TYPE_HEADER, VIEW_TYPE_ITEM, or VIEW_TYPE_FOOTER. You can confirm this by reviewing the SectionedViewHolder implementation. Unfortunately, since the type is represented as an integer rather than an enum, a default else clause with an exception is required.
|
test-Unit test failed, but no output was generated. Maybe a preliminary stage failed. |
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15037.apk |
tobiasKaminsky
left a comment
tobiasKaminsky
left a comment
There was a problem hiding this comment.
Please try to mimick the same behaviour as "+" button, instead of always showing bottom bar.
How to reproduce?
Demo
abc.mp4