fix: upload cancel & remove#16048
Merged
Merged
Conversation
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
74e2bfa to
3fedca1
Compare
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16048.apk |
AndyScherzinger
approved these changes
Dec 4, 2025
Member
I guess this is merged now, but more accurate terms would be: Cancel → Pause and as "cancel" sounds final. |
Member
|
Although the first one could also be called "Stop" and the second could remain "Remove". Whatever you think makes more sense with the rest of the feature's existing wording. |
Collaborator
Author
|
@kra-mo I will create another PR for that, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Changes
Fix cancel upload
Add remove upload
This update improves the handling of file uploads by clearly distinguishing between Cancel and Remove actions:
Cancel Upload:
Remove Upload:
These two actions provide necessary functionality for managing uploads, especially in cases such as
SYNC_CONFLICT, where users need to either resolve the conflict or remove the upload.This update also ensures that users can clearly distinguish between cancelling an upload and permanently removing it, reducing confusion and improving overall upload management.
How can we make it easier for users to understand the difference between these two actions? @kra-mo