Skip to content

fix(share-list-fragment): overriding metadata with wrong values#16810

Merged
alperozturk96 merged 3 commits intomasterfrom
fix/shared-file-list-metadata
Apr 8, 2026
Merged

fix(share-list-fragment): overriding metadata with wrong values#16810
alperozturk96 merged 3 commits intomasterfrom
fix/shared-file-list-metadata

Conversation

@alperozturk96
Copy link
Copy Markdown
Collaborator

Issue

Building OCFile from OCShare is not fully possible. In adapter we are using only OCFile thus this conversion is necessary. However buildOCFilesFromShares function overriding fileLenght and modificationTimestamp with -1 this was causing to show wrong information in shared file list.

Changes

  • If in same remote path we have a local file we can use that value for the file.
  • Instead of always creating OCFile to just show we can apply share data to existing file if file not exists we can create OCFile just like before as fallback.

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 7, 2026

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 7, 2026

Codacy

SpotBugs

CategoryBaseNew
Bad practice3636
Correctness6969
Dodgy code229229
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3434
Performance4242
Security1616
Total436436

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 7, 2026

APK file: https://github.com/nextcloud/android/actions/runs/24083703956/artifacts/6307787252
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96 alperozturk96 merged commit f96bab9 into master Apr 8, 2026
16 of 20 checks passed
@alperozturk96 alperozturk96 deleted the fix/shared-file-list-metadata branch April 8, 2026 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants