Skip to content

style(community): hide rc section for huawei build variant #16820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alperozturk96 wants to merge 1 commit into
base: master
Choose a base branch
from
+15 −2
Open

style(community): hide rc section for huawei build variant #16820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/src/main/java/com/nextcloud/utils/BuildHelper.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ package com.nextcloud.utils
import com.owncloud.android.BuildConfig

object BuildHelper {
const val GPLAY: String = "gplay"
fun isFlavourGPlay(): Boolean = BuildConfig.FLAVOR == "gplay"

fun isFlavourGPlay(): Boolean = GPLAY == BuildConfig.FLAVOR
fun isHuaweiFlavor(): Boolean = BuildConfig.FLAVOR == "huawei"
}
13 changes: 13 additions & 0 deletions app/src/main/java/com/owncloud/android/ui/fragment/community/CommunityFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import android.view.LayoutInflater
import android.view.View
import android.view.ViewGroup
import androidx.fragment.app.Fragment
import com.nextcloud.utils.BuildHelper
import com.nextcloud.utils.extensions.setHtmlContent
import com.owncloud.android.R
import com.owncloud.android.databinding.FragmentCommunityBinding
Expand All @@ -38,6 +39,9 @@ class CommunityFragment : Fragment() {
binding?.communityReleaseCandidateText?.movementMethod = LinkMovementMethod.getInstance()
setupViews()
setOnClickListeners()
if (BuildHelper.isHuaweiFlavor()) {
hideRCSection()
}
}

private fun setupViews() {
Expand Down Expand Up @@ -100,6 +104,15 @@ class CommunityFragment : Fragment() {
}
}

private fun hideRCSection() {
binding?.run {
communityReleaseCandidateHeadline.visibility = View.GONE
communityReleaseCandidateText.visibility = View.GONE
communityReleaseCandidateFdroid.visibility = View.GONE
communityReleaseCandidatePlaystore.visibility = View.GONE
}
}

override fun onDestroyView() {
super.onDestroyView()
binding = null
Expand Down
Loading