Skip to content

lint: do not warn on old target, we check this on our own#16943

Merged
tobiasKaminsky merged 1 commit intomasterfrom
oldTargetApi
Apr 30, 2026
Merged

lint: do not warn on old target, we check this on our own#16943
tobiasKaminsky merged 1 commit intomasterfrom
oldTargetApi

Conversation

@tobiasKaminsky
Copy link
Copy Markdown
Member

🖼️ Screenshots

🏚️ Before 🏡 After
B A

🏁 Checklist

  • Tests written, or not not needed

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky tobiasKaminsky requested a review from Copilot April 30, 2026 06:24
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Android app module’s lint configuration to suppress warnings about targeting an older API level, relying on project-specific enforcement instead.

Changes:

  • Added OldTargetApi to the disabled Android Lint checks in app.
  • Adjusted the disabled-check list formatting to accommodate the new entry.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions
Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness7167
Dodgy code218219
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3434
Performance4242
Security1616
Total426423

@github-actions
Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/25150760583/artifacts/6724294278
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@tobiasKaminsky tobiasKaminsky merged commit af0ddce into master Apr 30, 2026
16 of 24 checks passed
@tobiasKaminsky tobiasKaminsky deleted the oldTargetApi branch April 30, 2026 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants