Notification: move client creation to thread

[tobiasKaminsky]

Though I cannot reproduce it, it is good to have client creation in a thread.

Error message was:

0-08 15:43:05.598 22330-22330/? E/AndroidRuntime: FATAL EXCEPTION: main
    Process: com.nextcloud.client, PID: 22330
    java.lang.RuntimeException: Unable to start activity ComponentInfo{com.nextcloud.client/com.owncloud.android.ui.activity.NotificationsActivity}: java.lang.IllegalStateException: calling this from your main thread can lead to deadlock
        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2792)
        at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2870)
        at android.app.ActivityThread.-wrap11(Unknown Source:0)
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1601)
        at android.os.Handler.dispatchMessage(Handler.java:106)
        at android.os.Looper.loop(Looper.java:172)
        at android.app.ActivityThread.main(ActivityThread.java:6590)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)
     Caused by: java.lang.IllegalStateException: calling this from your main thread can lead to deadlock
        at android.accounts.AccountManager.ensureNotOnMainThread(AccountManager.java:2188)
        at android.accounts.AccountManager.-wrap1(Unknown Source:0)
        at android.accounts.AccountManager$AmsTask.internalGetResult(AccountManager.java:2291)
        at android.accounts.AccountManager$AmsTask.getResult(AccountManager.java:2329)
        at android.accounts.AccountManager$AmsTask.getResult(AccountManager.java:2326)
        at android.accounts.AccountManager.blockingGetAuthToken(AccountManager.java:1514)
        at com.owncloud.android.lib.common.accounts.AccountUtils.getCredentialsForAccount(AccountUtils.java:209)
        at com.owncloud.android.lib.common.OwnCloudAccount.loadCredentials(OwnCloudAccount.java:126)
        at com.owncloud.android.lib.common.SingleSessionManager.getClientFor(SingleSessionManager.java:127)
        at com.owncloud.android.lib.common.DynamicSessionManager.getClientFor(DynamicSessionManager.java:38)
        at com.owncloud.android.lib.common.DynamicSessionManager.getClientFor(DynamicSessionManager.java:30)
        at com.owncloud.android.ui.activity.NotificationsActivity.setupContent(NotificationsActivity.java:239)
        at com.owncloud.android.ui.activity.NotificationsActivity.onCreate(NotificationsActivity.java:160)
        at android.app.Activity.performCreate(Activity.java:7023)
        at android.app.Activity.performCreate(Activity.java:7014)
        at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1215)
        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2745)
        at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2870) 
        at android.app.ActivityThread.-wrap11(Unknown Source:0) 
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1601) 
        at android.os.Handler.dispatchMessage(Handler.java:106) 
        at android.os.Looper.loop(Looper.java:172) 
        at android.app.ActivityThread.main(ActivityThread.java:6590) 
        at java.lang.reflect.Method.invoke(Native Method) 
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438) 
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807) 

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

[AndyScherzinger]

👍 looks good to me code-wise! 👍

[nextcloud-android-bot]

Lint

Type	Master	PR
Warnings	97	97
Errors

FindBugs (new)

Warning Type	Number
Bad practice Warnings	35
Correctness Warnings	167
Internationalization Warnings	14
Malicious code vulnerability Warnings	10
Multithreaded correctness Warnings	9
Performance Warnings	124
Security Warnings	203
Dodgy code Warnings	139
Total	701

FindBugs (master)

Warning Type	Number
Bad practice Warnings	35
Correctness Warnings	167
Internationalization Warnings	14
Malicious code vulnerability Warnings	10
Multithreaded correctness Warnings	9
Performance Warnings	124
Security Warnings	203
Dodgy code Warnings	139
Total	701

[codecov]

Codecov Report

Merging #3153 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             master   #3153      +/-   ##
===========================================
- Coverage      6.48%   6.46%   -0.02%     
  Complexity        1       1              
===========================================
  Files           307     307              
  Lines         30111   30112       +1     
  Branches       4318    4319       +1     
===========================================
- Hits           1953    1948       -5     
- Misses        27866   27869       +3     
- Partials        292     295       +3

Impacted Files	Coverage Δ	Complexity Δ
...oud/android/ui/activity/NotificationsActivity.java	0% <0%> (ø)	0 <0> (ø)	⬇️
.../third_parties/daveKoeller/AlphanumComparator.java	80.95% <0%> (-2.39%)	0% <0%> (ø)
...in/java/com/owncloud/android/datamodel/OCFile.java	62.64% <0%> (-1.17%)	0% <0%> (ø)