Incorporated Checkstyle, findbugs, pmd and lint#321
Incorporated Checkstyle, findbugs, pmd and lint#321AndyScherzinger merged 1 commit intonextcloud:masterfrom
Conversation
|
Awesome work @djubreel 👍 @tobiasKaminsky please also have a look and if you are okay with it please merge. I did a dry run locally (gradlew.bat check) and I also set |
|
Code is 👍 |
|
One minor thing:
|
|
I would say let's wait with the "documentation" until the fails are fixes, then activate it in the builds and put it into the documentation. We can merge right away since the checks will fail if you execute them, but they aren't activated in our builds just yet. |
|
@djubreel The PR has been merged! 🎉 Thank you very much for this contribution!!! 🚀 |
Incorporated checkstyle, findbugs, pmd and lint for code quality. Most rules are not set yet as that would be needing a lot of changes in the code base so the rules can be added bit by bit and corresponding changes effected in codebase. @AndyScherzinger