Skip to content

Conversation

@tobiasKaminsky
Copy link
Member

  • bump to 3.5.0 RC1
  • do not show what's new slides

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Jan 29, 2019

👍

Approved with PullApprove

@AndyScherzinger
Copy link
Member

@tobiasKaminsky btw shouldn't the branch be named stable-3.5.x? because it is not: https://github.com/nextcloud/android/commits/stable-3.5

@tobiasKaminsky
Copy link
Member Author

@tobiasKaminsky btw shouldn't the branch be named stable-3.5.x?

The backport bot can automatically detect the milestone, if it is without ".x".
So if we would now say "/ backport to stable-3.5" then we get on the new PR the correct labels and the milestone 3.5.1 set (if it is there)

@codecov
Copy link

codecov bot commented Jan 29, 2019

Codecov Report

Merging #3509 into stable-3.5 will decrease coverage by <.01%.
The diff coverage is 0%.

@@               Coverage Diff               @@
##             stable-3.5   #3509      +/-   ##
===============================================
- Coverage          6.12%   6.12%   -0.01%     
  Complexity            1       1              
===============================================
  Files               316     316              
  Lines             30723   30719       -4     
  Branches           4397    4395       -2     
===============================================
- Hits               1883    1882       -1     
+ Misses            28558   28554       -4     
- Partials            282     283       +1
Impacted Files Coverage Δ Complexity Δ
...owncloud/android/ui/activity/WhatsNewActivity.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../third_parties/daveKoeller/AlphanumComparator.java 80.95% <0%> (-1.2%) 0% <0%> (ø)

@codecov
Copy link

codecov bot commented Jan 29, 2019

Codecov Report

Merging #3509 into stable-3.5 will increase coverage by <.01%.
The diff coverage is 0%.

@@               Coverage Diff               @@
##             stable-3.5   #3509      +/-   ##
===============================================
+ Coverage          6.12%   6.12%   +<.01%     
  Complexity            1       1              
===============================================
  Files               316     316              
  Lines             30723   30719       -4     
  Branches           4397    4395       -2     
===============================================
  Hits               1883    1883              
+ Misses            28558   28554       -4     
  Partials            282     282
Impacted Files Coverage Δ Complexity Δ
...owncloud/android/ui/activity/WhatsNewActivity.java 0% <0%> (ø) 0 <0> (ø) ⬇️

do not show what's new slides
remove unused ressources
fix findbugs

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot
Copy link
Collaborator

Lint

Typestable-3.5PR
Warnings6969
Errors00

FindBugs (new)

Warning TypeNumber
Bad practice Warnings33
Correctness Warnings156
Internationalization Warnings15
Malicious code vulnerability Warnings12
Multithreaded correctness Warnings9
Performance Warnings118
Security Warnings58
Dodgy code Warnings134
Total535

FindBugs (stable-3.5)

Warning TypeNumber
Bad practice Warnings33
Correctness Warnings156
Internationalization Warnings15
Malicious code vulnerability Warnings12
Multithreaded correctness Warnings9
Performance Warnings118
Security Warnings58
Dodgy code Warnings134
Total535

Findbugs increased!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants