Skip to content

Conversation

@tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented May 14, 2019

Fix #4000
Open file from

  • notification list
  • push notification

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

@tobiasKaminsky
Copy link
Member Author

2019-05-14-123829 2019-05-14-123834

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@codecov
Copy link

codecov bot commented May 14, 2019

Codecov Report

Merging #4019 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             master   #4019      +/-   ##
===========================================
- Coverage       6.7%   6.69%   -0.01%     
  Complexity        1       1              
===========================================
  Files           326     326              
  Lines         30884   30930      +46     
  Branches       4406    4412       +6     
===========================================
+ Hits           2070    2071       +1     
- Misses        28516   28561      +45     
  Partials        298     298
Impacted Files Coverage Δ Complexity Δ
...cloud/android/ui/activity/FileDisplayActivity.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ud/android/ui/adapter/NotificationListAdapter.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ava/com/owncloud/android/jobs/NotificationJob.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...wncloud/android/providers/FileContentProvider.java 18.91% <0%> (-0.22%) 0% <0%> (ø)
...loud/android/datamodel/FileDataStorageManager.java 11.85% <0%> (-0.05%) 0% <0%> (ø)
...wncloud/android/ui/fragment/ShareFileFragment.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...android/ui/dialog/SharePasswordDialogFragment.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...android/ui/fragment/FileDetailSharingFragment.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...om/owncloud/android/ui/dialog/SendShareDialog.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
... and 4 more

moved string to final constant

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky
Copy link
Member Author

Thank you for your review @ezaquarii. I changed it 👍

@nextcloud nextcloud deleted a comment May 16, 2019
@nextcloud-android-bot
Copy link
Collaborator

Codacy

284

Lint

TypemasterPR
Warnings5858
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings25
Correctness Warnings79
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings122
Security Warnings47
Dodgy code Warnings140
Total438

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings25
Correctness Warnings79
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings122
Security Warnings47
Dodgy code Warnings140
Total438

@tobiasKaminsky tobiasKaminsky merged commit fabe3b2 into master May 22, 2019
@tobiasKaminsky tobiasKaminsky deleted the fileInNotification branch May 22, 2019 08:59
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.7.0 milestone May 22, 2019
tobiasKaminsky added a commit that referenced this pull request May 23, 2019
a8829c6 Refactor ConnectivityUtils (#4008)
9cbb677 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
c988459 Merge commit '1f290419662c8058cd4bd90a161222f4150f6f25'
1f29041 revert commentig
fabe3b2 open file from notification (#4019)
b3312aa linewrap
415deca [tx-robot] updated from transifex
6a79f10 daily dev 20190522
tobiasKaminsky added a commit that referenced this pull request May 23, 2019
a8829c6 Refactor ConnectivityUtils (#4008)
9cbb677 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
c988459 Merge commit '1f290419662c8058cd4bd90a161222f4150f6f25'
1f29041 revert commentig
fabe3b2 open file from notification (#4019)
b3312aa linewrap
415deca [tx-robot] updated from transifex
6a79f10 daily dev 20190522
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(Push) Notification about mentioned in file/folder should open it

5 participants