-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
open file from notification #4019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
a4ec1f9 to
22e605b
Compare
Codecov Report
@@ Coverage Diff @@
## master #4019 +/- ##
===========================================
- Coverage 6.7% 6.69% -0.01%
Complexity 1 1
===========================================
Files 326 326
Lines 30884 30930 +46
Branches 4406 4412 +6
===========================================
+ Hits 2070 2071 +1
- Misses 28516 28561 +45
Partials 298 298
|
ezaquarii
reviewed
May 16, 2019
src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.java
Outdated
Show resolved
Hide resolved
src/main/java/com/owncloud/android/ui/adapter/NotificationListAdapter.java
Outdated
Show resolved
Hide resolved
moved string to final constant Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Member
Author
|
Thank you for your review @ezaquarii. I changed it 👍 |
Collaborator
Codacy284Lint
SpotBugs (new)
SpotBugs (master)
|
AndyScherzinger
approved these changes
May 16, 2019
tobiasKaminsky
added a commit
that referenced
this pull request
May 23, 2019
a8829c6 Refactor ConnectivityUtils (#4008) 9cbb677 Drone: update FindBugs results to reflect reduced error/warning count [skip ci] c988459 Merge commit '1f290419662c8058cd4bd90a161222f4150f6f25' 1f29041 revert commentig fabe3b2 open file from notification (#4019) b3312aa linewrap 415deca [tx-robot] updated from transifex 6a79f10 daily dev 20190522
tobiasKaminsky
added a commit
that referenced
this pull request
May 23, 2019
a8829c6 Refactor ConnectivityUtils (#4008) 9cbb677 Drone: update FindBugs results to reflect reduced error/warning count [skip ci] c988459 Merge commit '1f290419662c8058cd4bd90a161222f4150f6f25' 1f29041 revert commentig fabe3b2 open file from notification (#4019) b3312aa linewrap 415deca [tx-robot] updated from transifex 6a79f10 daily dev 20190522
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Fix #4000
Open file from
Signed-off-by: tobiasKaminsky tobias@kaminsky.me