Skip to content

Conversation

@tobiasKaminsky
Copy link
Member

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

@tobiasKaminsky
Copy link
Member Author

tobiasKaminsky commented May 31, 2019

Needs testing with nextcloud/richdocuments#526

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky tobiasKaminsky force-pushed the richDocumentsGrabFocus branch from d0eafed to df6f4cf Compare June 4, 2019 09:25
@codecov
Copy link

codecov bot commented Jun 4, 2019

Codecov Report

Merging #4106 into master will increase coverage by 0.55%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #4106      +/-   ##
============================================
+ Coverage     13.86%   14.42%   +0.55%     
  Complexity        1        1              
============================================
  Files           332      332              
  Lines         31068    31071       +3     
  Branches       4431     4431              
============================================
+ Hits           4309     4481     +172     
+ Misses        26033    25800     -233     
- Partials        726      790      +64
Impacted Files Coverage Δ Complexity Δ
...loud/android/ui/activity/RichDocumentsWebView.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../third_parties/daveKoeller/AlphanumComparator.java 82.14% <0%> (-1.2%) 0% <0%> (ø)
...xtcloud/client/account/UserAccountManagerImpl.java 47.91% <0%> (ø) 0% <0%> (ø) ⬇️
...in/java/com/owncloud/android/datamodel/OCFile.java 62.84% <0%> (+0.45%) 0% <0%> (ø) ⬇️
...n/java/com/owncloud/android/utils/BitmapUtils.java 53.37% <0%> (+0.67%) 0% <0%> (ø) ⬇️
...loud/android/ui/fragment/ExtendedListFragment.java 48.08% <0%> (+0.88%) 0% <0%> (ø) ⬇️
.../java/com/owncloud/android/utils/DisplayUtils.java 19.85% <0%> (+1.12%) 0% <0%> (ø) ⬇️
...cloud/android/ui/activity/FileDisplayActivity.java 19.37% <0%> (+1.76%) 0% <0%> (ø) ⬇️
.../owncloud/android/ui/activity/ToolbarActivity.java 59.42% <0%> (+2.89%) 0% <0%> (ø) ⬇️
.../java/com/owncloud/android/utils/MimeTypeUtil.java 82.6% <0%> (+4.34%) 0% <0%> (ø) ⬇️
... and 5 more

@tobiasKaminsky
Copy link
Member Author

Tested with local collabora setup.

@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/9617.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Codacy

310

Lint

TypemasterPR
Warnings5858
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings25
Correctness Warnings68
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings121
Security Warnings47
Dodgy code Warnings137
Total423

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings25
Correctness Warnings68
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings121
Security Warnings47
Dodgy code Warnings137
Total423

@AndyScherzinger AndyScherzinger merged commit 4e12a88 into master Jun 4, 2019
@AndyScherzinger AndyScherzinger deleted the richDocumentsGrabFocus branch June 4, 2019 15:08
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.7.0 milestone Jun 4, 2019
tobiasKaminsky added a commit that referenced this pull request Jun 5, 2019
af0dc69 Merge pull request #4113 from nextcloud/detailNullable
4e12a88 Merge pull request #4106 from nextcloud/richDocumentsGrabFocus
df6f4cf grab focus on resume
7d51dfd second fragment might be null
09cca69 daily dev 20190604
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants