Only trigger media scans for media files

[grote]

This also removes the last instance of generateResizedImage() which was
crashing NextCloud with OOM errors.

Fixes #4999

[AndyScherzinger]

Just one issue where I am unsure if @grote is right or if we need to keep it (https://github.com/nextcloud/android/pull/5018/files#r358322910)

[codecov]

Codecov Report

Merging #5018 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #5018      +/-   ##
============================================
+ Coverage     17.53%   17.54%   +<.01%     
  Complexity        3        3              
============================================
  Files           385      385              
  Lines         32679    32686       +7     
  Branches       4594     4601       +7     
============================================
+ Hits           5731     5734       +3     
- Misses        26018    26023       +5     
+ Partials        930      929       -1

Impacted Files	Coverage Δ	Complexity Δ
...ncloud/android/operations/RenameFileOperation.java	0% <0%> (ø)	0 <0> (ø)	⬇️
.../java/com/owncloud/android/utils/MimeTypeUtil.java	86.4% <0%> (-0.22%)	0 <0> (ø)
...ncloud/android/operations/UploadFileOperation.java	24.87% <0%> (-0.57%)	0 <0> (ø)
...loud/android/datamodel/FileDataStorageManager.java	36.19% <0%> (-0.35%)	0 <0> (ø)
...wncloud/android/files/services/FileDownloader.java	16.85% <0%> (-0.07%)	0 <0> (ø)
...ncloud/android/operations/RemoveFileOperation.java	43.33% <0%> (-4.95%)	0 <0> (ø)
...n/java/com/owncloud/android/utils/BitmapUtils.java	43.91% <0%> (-9.46%)	0% <0%> (ø)
...loud/android/datamodel/ThumbnailsCacheManager.java	32.29% <0%> (-1.46%)	0% <0%> (ø)
...oud/android/operations/RefreshFolderOperation.java	56.95% <0%> (-0.44%)	0% <0%> (ø)
... and 7 more

[tobiasKaminsky]

--> do not remove it, but check for mimetype and do this only on images.

[nextcloud-android-bot]

Here is an overview of what got changed by this pull request:

Issues
======
- Added 1
           

Complexity increasing per file
==============================
- src/main/java/com/owncloud/android/operations/RemoveFileOperation.java  1
- src/main/java/com/owncloud/android/datamodel/FileDataStorageManager.java  1
         

See the complete overview on Codacy

[nextcloud-android-bot]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12020.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[nextcloud-android-bot]

Codacy

328

Lint

Type	master	PR
Warnings	73	73
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	26
Correctness Warnings	70
Internationalization Warnings	13
Malicious code vulnerability Warnings	5
Multithreaded correctness Warnings	9
Performance Warnings	106
Security Warnings	44
Dodgy code Warnings	136
Total	409

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	26
Correctness Warnings	70
Internationalization Warnings	13
Malicious code vulnerability Warnings	5
Multithreaded correctness Warnings	9
Performance Warnings	106
Security Warnings	44
Dodgy code Warnings	136
Total	409

[AndyScherzinger]

Thanks for the fix @grote ❤️