Skip to content

Conversation

@dependabot-preview
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Dec 20, 2019

Bumps butterknife-compiler from 10.2.0 to 10.2.1.

Changelog

Sourced from butterknife-compiler's changelog.

Version 10.2.1 (2019-12-19)

Heads up: Development on this tool is winding down as view binding will be stable in AS/AGP 3.6.

  • New: Make R2-generating Gradle task cacheable by default.
  • Fix: R2 classes now generate their own unique values for entries. This ensures that the annotation processor can always do a reverse mapping from ID back to name and type. In AGP 3.6.0, the R.txt symbol table that was previously used as a source for values now uses 0 for every entry which required this change.
  • Fix: Lint check for R2 values now properly handles static imports for entries.
Commits
  • 88689a7 Prepare version 10.2.1
  • 14c941f Merge pull request #1574 from JakeWharton/jakew/fake-ids/2019-12-18
  • bb27b5a Use fake ID values for R2
  • 7308431 Merge pull request #1562 from dkonurov/fix_static_import
  • 8c86529 Properly handle R references as static imports
  • e4974f5 Merge pull request #1568 from lptr/fix-input-path-sensitivity
  • d74d3b3 Make R2Generator task cacheable by default
  • aeba09e Fix input path sensitivity for R2Generator task
  • 4123465 Last call
  • 90f509b Prepare next development version
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @AndyScherzinger.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added 3. to review dependencies Pull requests that update a dependency file labels Dec 20, 2019
@codecov
Copy link

codecov bot commented Dec 20, 2019

Codecov Report

Merging #5042 into master will decrease coverage by 0.19%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master    #5042     +/-   ##
===========================================
- Coverage     17.72%   17.52%   -0.2%     
  Complexity        3        3             
===========================================
  Files           389      389             
  Lines         32893    32893             
  Branches       4627     4627             
===========================================
- Hits           5829     5764     -65     
- Misses        26111    26181     +70     
+ Partials        953      948      -5
Impacted Files Coverage Δ Complexity Δ
...services/firebase/NCFirebaseInstanceIDService.java 0% <0%> (-87.5%) 0% <0%> (ø)
...va/com/owncloud/android/ui/SquareLinearLayout.java 0% <0%> (-50%) 0% <0%> (ø)
.../services/firebase/NCFirebaseMessagingService.java 0% <0%> (-7.15%) 0% <0%> (ø)
...loud/android/datamodel/ThumbnailsCacheManager.java 26.45% <0%> (-5.3%) 0% <0%> (ø)
.../third_parties/daveKoeller/AlphanumComparator.java 79.76% <0%> (-3.58%) 0% <0%> (ø)
...owncloud/android/ui/adapter/OCFileListAdapter.java 25.09% <0%> (-3.25%) 0% <0%> (ø)
...om/owncloud/android/utils/FileSortOrderByName.java 14.28% <0%> (-2.86%) 0% <0%> (ø)
...xtcloud/client/preferences/AppPreferencesImpl.java 50.81% <0%> (-2.71%) 0% <0%> (ø)
.../java/com/owncloud/android/utils/DisplayUtils.java 24.89% <0%> (-0.85%) 0% <0%> (ø)
...oud/android/ui/activity/SyncedFoldersActivity.java 25.06% <0%> (-0.76%) 0% <0%> (ø)
... and 9 more

Bumps [butterknife-compiler](https://github.com/JakeWharton/butterknife) from 10.2.0 to 10.2.1.
- [Release notes](https://github.com/JakeWharton/butterknife/releases)
- [Changelog](https://github.com/JakeWharton/butterknife/blob/master/CHANGELOG.md)
- [Commits](JakeWharton/butterknife@10.2.0...10.2.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot force-pushed the dependabot/gradle/com.jakewharton-butterknife-compiler-10.2.1 branch from 6aa9f08 to 9e61eba Compare December 20, 2019 07:34
@AndyScherzinger AndyScherzinger merged commit 4899561 into master Dec 20, 2019
@delete-merged-branch delete-merged-branch bot deleted the dependabot/gradle/com.jakewharton-butterknife-compiler-10.2.1 branch December 20, 2019 07:36
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.10.0 milestone Dec 20, 2019
@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12076.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Codacy

327

Lint

TypemasterPR
Warnings7474
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings71
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings106
Security Warnings44
Dodgy code Warnings139
Total413

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings71
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings106
Security Warnings44
Dodgy code Warnings139
Total413

tobiasKaminsky added a commit that referenced this pull request Dec 21, 2019
a28d65c Merge pull request #5047 from nextcloud/nickvergessen-patch-1
70f20b3 Merge pull request #5040 from nextcloud/dependabot/gradle/com.android.support.test.espresso-espresso-intents-3.0.2
c8f8fbb Change order of steps and result of those steps
89bbb82 Bump espresso-intents from 2.2.1 to 3.0.2
4899561 Merge pull request #5042 from nextcloud/dependabot/gradle/com.jakewharton-butterknife-compiler-10.2.1
9e61eba Bump butterknife-compiler from 10.2.0 to 10.2.1
aff5c47 Merge pull request #5044 from nextcloud/dependabot/gradle/com.jakewharton-butterknife-10.2.1
7240022 [tx-robot] updated from transifex
1caf02a daily dev 20191220
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants