Skip to content

Conversation

@tobiasKaminsky
Copy link
Member

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky
Copy link
Member Author

/backport to stable-3.10

@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12185.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Codacy

637

Lint

TypemasterPR
Warnings7474
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings71
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings107
Security Warnings44
Dodgy code Warnings139
Total414

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings71
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings107
Security Warnings44
Dodgy code Warnings139
Total414

@codecov
Copy link

codecov bot commented Jan 9, 2020

Codecov Report

Merging #5128 into master will increase coverage by 0.07%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #5128      +/-   ##
============================================
+ Coverage     17.62%   17.69%   +0.07%     
  Complexity        3        3              
============================================
  Files           392      392              
  Lines         33116    33116              
  Branches       4651     4651              
============================================
+ Hits           5836     5860      +24     
+ Misses        26329    26298      -31     
- Partials        951      958       +7
Impacted Files Coverage Δ Complexity Δ
...om/owncloud/android/ui/activity/EditorWebView.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...services/firebase/NCFirebaseInstanceIDService.java 62.5% <0%> (-25%) 0% <0%> (ø)
...oud/android/operations/RefreshFolderOperation.java 58.94% <0%> (-2.04%) 0% <0%> (ø)
...cloud/android/ui/activity/FileDisplayActivity.java 20.12% <0%> (-0.08%) 0% <0%> (ø)
...loud/android/datamodel/FileDataStorageManager.java 35.43% <0%> (+0.23%) 0% <0%> (ø) ⬇️
...owncloud/android/ui/adapter/OCFileListAdapter.java 28.64% <0%> (+0.36%) 0% <0%> (ø) ⬇️
...loud/android/datamodel/ThumbnailsCacheManager.java 32.66% <0%> (+0.36%) 0% <0%> (ø) ⬇️
...oud/android/ui/activity/SyncedFoldersActivity.java 26.31% <0%> (+0.5%) 0% <0%> (ø) ⬇️
.../java/com/owncloud/android/utils/DisplayUtils.java 25.73% <0%> (+0.84%) 0% <0%> (ø) ⬇️
.../third_parties/daveKoeller/AlphanumComparator.java 83.33% <0%> (+1.19%) 0% <0%> (ø) ⬇️
... and 3 more

@backportbot-nextcloud
Copy link

backport to stable-3.10 in #5134

tobiasKaminsky added a commit that referenced this pull request Jan 10, 2020
8a343be Merge pull request #5133 from nextcloud/notificationTask
6cd1b75 Merge pull request #5121 from nextcloud/newIcon
9fa4060 Merge pull request #5128 from nextcloud/closeEditor
4b073e9 task needs to be a new object for every button
383d892 Merge pull request #5017 from grote/5015-dp-remove-npe
56e6ed5 editor: click on snackbar closes webview for real
99eb991 [tx-robot] updated from transifex
e0beda8 daily dev 20200109
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants