-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
editor: click on snackbar closes webview for real #5128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Member
Author
|
/backport to stable-3.10 |
Collaborator
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12185.apk |
Collaborator
Codacy637Lint
SpotBugs (new)
SpotBugs (master)
|
Codecov Report
@@ Coverage Diff @@
## master #5128 +/- ##
============================================
+ Coverage 17.62% 17.69% +0.07%
Complexity 3 3
============================================
Files 392 392
Lines 33116 33116
Branches 4651 4651
============================================
+ Hits 5836 5860 +24
+ Misses 26329 26298 -31
- Partials 951 958 +7
|
AndyScherzinger
approved these changes
Jan 9, 2020
|
backport to stable-3.10 in #5134 |
tobiasKaminsky
added a commit
that referenced
this pull request
Jan 10, 2020
8a343be Merge pull request #5133 from nextcloud/notificationTask 6cd1b75 Merge pull request #5121 from nextcloud/newIcon 9fa4060 Merge pull request #5128 from nextcloud/closeEditor 4b073e9 task needs to be a new object for every button 383d892 Merge pull request #5017 from grote/5015-dp-remove-npe 56e6ed5 editor: click on snackbar closes webview for real 99eb991 [tx-robot] updated from transifex e0beda8 daily dev 20200109
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Signed-off-by: tobiasKaminsky tobias@kaminsky.me