Skip to content

Improve synced folder dialog#5628

Open
tobiasKaminsky wants to merge 1 commit intomasterfrom
upload
Open

Improve synced folder dialog#5628
tobiasKaminsky wants to merge 1 commit intomasterfrom
upload

Conversation

@tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Mar 11, 2020

binding.syncEnabled.setOnCheckedChangeListener((buttonView, isChecked) -> setEnabled(!mSyncedFolder.isEnabled()));

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

Testing

/

- fix wrongly clicklable upload behaviour

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13031.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
- Added 1
           

See the complete overview on Codacy

public void onDestroy() {
super.onDestroy();

binding = null;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nextcloud-android-bot
Copy link
Collaborator

Codacy

375

Lint

TypemasterPR
Warnings96110
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings70
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings77
Security Warnings44
Dodgy code Warnings141
Total385

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings70
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings77
Security Warnings44
Dodgy code Warnings141
Total385

Lint increased!

@nextcloud-android-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants