Make external storage permission optional

[AlvaroBrey]

Fixes #9343
Fixes #9845

• Don't force permissions on app launch
• Force permissions for upload activity
• Force permissions for synced folders activity
• Allow choosing between All Files and just READ_EXTERNAL_STORAGE in SDK 30+
  • Allow disabling All Files completely (through setup.xml? Just remove the permission from the manifest, code detects that)
  • Handle cases where there's no way to obtain All Files (No system activity for All Files permission #9845 ). Probably just assume that All Files is not available...
  • Properly designed choice dialog
• Tests written, or not not needed

[codecov]

Codecov Report

Merging #9873 (85433c5) into master (55c9811) will increase coverage by 0.66%.
The diff coverage is 6.71%.

❗ Current head 85433c5 differs from pull request most recent head 1a9014e. Consider uploading reports for the commit 1a9014e to get more accurate results

@@            Coverage Diff             @@
##           master    #9873      +/-   ##
==========================================
+ Coverage   30.50%   31.16%   +0.66%     
==========================================
  Files         513      514       +1     
  Lines       38890    38919      +29     
  Branches     5473     5477       +4     
==========================================
+ Hits        11864    12131     +267     
+ Misses      25234    24953     -281     
- Partials     1792     1835      +43     

Impacted Files	Coverage Δ
...m/nextcloud/client/preferences/AppPreferences.java	0.00% <ø> (ø)
...xtcloud/client/preferences/AppPreferencesImpl.java	57.89% <0.00%> (ø)
.../com/owncloud/android/datamodel/MediaProvider.java	25.53% <0.00%> (ø)
...cloud/android/ui/activity/SyncedFoldersActivity.kt	18.05% <0.00%> (ø)
...droid/ui/dialog/StoragePermissionDialogFragment.kt	0.00% <0.00%> (ø)
.../java/com/owncloud/android/utils/PermissionUtil.kt	9.09% <5.76%> (ø)
...cloud/android/ui/activity/UploadFilesActivity.java	31.22% <26.31%> (ø)
...cloud/android/ui/activity/FileDisplayActivity.java	24.82% <33.33%> (ø)
.../java/com/nextcloud/client/mixins/MixinRegistry.kt
...m/nextcloud/client/migrations/MigrationsManager.kt
... and 1024 more

[AlvaroBrey]

@nextcloud/designers I'd like to request feedback on the dialog design. If you have a better idea of how to present these choices, please let me know.

#9343 for context

This is the dialog shown at app startup, at which point the permission is optional. The text will change in cases where permissions are absolutely required (file upload, autosync setup) to reflect that ("Permissions needed" or something like that).
Of course the texts are also up for suggestions.

Click to view screenshot

Extra food for thought: we may want to skip this optional, first-time permission request; after all it will be requested when actually needed. This makes app usage a bit more seamless first time, BUT autoupload folder detection won't work unless users grant the permissions first.

[jancborchardt]

@AlvaroBrey text looks good, just 2 questions:

• It says "permissions to access external storage" – is it enough to just say "permissions to access storage", or is that permission there automatically?
• The dialog has no border radius, as per guidelines there’s a bit of border-radius to soften it (would also look better with our general design): https://material.io/components/dialogs#usage

[AlvaroBrey]

* It says "permissions to access **external** storage" – is it enough to just say "permissions to access storage", or is that permission there automatically?

* The dialog has no border radius, as per guidelines there’s a bit of border-radius to soften it (would also look better with our general design): https://material.io/components/dialogs#usage

Done in 979a939

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/9873.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[AlvaroBrey]

@tobiasKaminsky ready for re-review

[nextcloud-android-bot]

Codacy

Lint

Type	master	PR
Warnings	93	93
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	28
Correctness Warnings	78
Experimental Warnings	1
Internationalization Warnings	9
Malicious code vulnerability Warnings	57
Multithreaded correctness Warnings	9
Performance Warnings	67
Security Warnings	29
Dodgy code Warnings	350
Total	628

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	28
Correctness Warnings	78
Experimental Warnings	1
Internationalization Warnings	9
Malicious code vulnerability Warnings	57
Multithreaded correctness Warnings	9
Performance Warnings	67
Security Warnings	29
Dodgy code Warnings	350
Total	628

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/9873.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.