Skip to content

fix(filesplugin): file actions invisible on NC33+ (registry mismatch, #848)#855

Merged
oleksandr-nc merged 1 commit intomainfrom
fix/848-fileaction-registry-mismatch
May 4, 2026
Merged

fix(filesplugin): file actions invisible on NC33+ (registry mismatch, #848)#855
oleksandr-nc merged 1 commit intomainfrom
fix/848-fileaction-registry-mismatch

Conversation

@oleksandr-nc
Copy link
Copy Markdown
Contributor

@oleksandr-nc oleksandr-nc commented Apr 30, 2026

Fixes #848.

AppAPI bundles @nextcloud/files@4.0.0-beta.7, which still uses the legacy window._nc_fileactions array, while NC33+ ships @nextcloud/files@4.0.0 and reads from the new versioned scoped registry at window._nc_files_scope.v4_0.fileActions - so file actions registered by ExApps land in a registry the Files app never reads, and never become visible.

@oleksandr-nc oleksandr-nc force-pushed the fix/848-fileaction-registry-mismatch branch 6 times, most recently from fa43b5d to 9aae687 Compare April 30, 2026 12:23
@oleksandr-nc oleksandr-nc marked this pull request as ready for review May 4, 2026 04:44
@oleksandr-nc oleksandr-nc requested a review from kyteinsky May 4, 2026 04:44
Copy link
Copy Markdown
Collaborator

@kyteinsky kyteinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Comment thread tests/exapp_integration/test_user_impersonation.py Outdated
Comment thread .github/workflows/tests-exapp-integration.yml
Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>

test(exapp_integration): add Playwright file action menu regression

Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>

Co-authored-by: kyteinsky <20724224+kyteinsky@users.noreply.github.com>
@oleksandr-nc oleksandr-nc force-pushed the fix/848-fileaction-registry-mismatch branch from 72dd492 to 03a3277 Compare May 4, 2026 05:53
@oleksandr-nc oleksandr-nc merged commit 801b0f4 into main May 4, 2026
52 checks passed
@oleksandr-nc oleksandr-nc deleted the fix/848-fileaction-registry-mismatch branch May 4, 2026 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FileActionMenu entry does not appear

2 participants