Skip to content

refactor: simplify enabled-state check in validateExAppRequestToNC#860

Merged
oleksandr-nc merged 1 commit into
mainfrom
chore/code-simplification
May 11, 2026
Merged

refactor: simplify enabled-state check in validateExAppRequestToNC#860
oleksandr-nc merged 1 commit into
mainfrom
chore/code-simplification

Conversation

@oleksandr-nc
Copy link
Copy Markdown
Contributor

Drops the if (!$isDav) wrapper around the path-info

The branch was a leftover from the old API-scope system (removed in #373) — there's nothing left for it to gate.

Net: -2 lines, one less branch, single code path for OCS and DAV.

Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
@oleksandr-nc oleksandr-nc requested a review from kyteinsky May 11, 2026 05:30
@oleksandr-nc oleksandr-nc merged commit 2f76f5e into main May 11, 2026
52 checks passed
@oleksandr-nc oleksandr-nc deleted the chore/code-simplification branch May 11, 2026 05:52
@oleksandr-nc
Copy link
Copy Markdown
Contributor Author

/backport to stable33

@oleksandr-nc
Copy link
Copy Markdown
Contributor Author

/backport to stable32

@oleksandr-nc
Copy link
Copy Markdown
Contributor Author

/backport to stable31

@oleksandr-nc
Copy link
Copy Markdown
Contributor Author

/backport to stable30

@backportbot
Copy link
Copy Markdown

backportbot Bot commented May 11, 2026

The backport to stable32 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable32
git pull origin stable32

# Create the new backport branch
git checkout -b backport/860/stable32

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick ecaaec96

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/860/stable32

Error: Failed to check for changes with origin/stable32: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot
Copy link
Copy Markdown

backportbot Bot commented May 11, 2026

The backport to stable31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable31
git pull origin stable31

# Create the new backport branch
git checkout -b backport/860/stable31

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick ecaaec96

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/860/stable31

Error: Failed to check for changes with origin/stable31: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot
Copy link
Copy Markdown

backportbot Bot commented May 11, 2026

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/860/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick ecaaec96

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/860/stable30

Error: Failed to check for changes with origin/stable30: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants