fix: proxy route leading slash#874
Conversation
…ash (HaRP alignment) Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR updates route-matching behavior in 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
|
/backport to stable34 |
|
/backport to stable33 |
|
/backport to stable32 |
|
/backport to stable31 |
|
/backport to stable30 |
Restores route matching for ExApps that declare routes in the canonical regex form documented in HaRP (
<url>^/path$</url>, e.g. app-skeleton-python).ExAppProxyController::passesExAppProxyRoutesChecksbuilds a^-anchored regex from$route['url']and matches it against$other.Symfony strips the leading slash, so
$otheris bare (e.g.public/page). But route URLs are typically written against the full path.To avoid breaking ExApps whose info.xml still uses the non-canonical bare form (currently context_chat_backend's
<url>downloadLogs</url>), the second commit adds a one-iteration fallback: if the canonical subject didn't match, retry against the bare subject and emit a debug log identifying the ExApp and route so maintainers know to migrate. Marked TODO(deprecation) for removal once known legacy apps have shipped the canonical form.