Skip to content

[stable34] fix: proxy route leading slash #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oleksandr-nc merged 2 commits into from
May 15, 2026
+12 −1
Merged

[stable34] fix: proxy route leading slash #875

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d3ed63
fix(proxy): match route URL against request path including leading sl…
oleksandr-nc May 15, 2026
a3a9225
fix(proxy): add transitional bare-path fallback for legacy route URLs
oleksandr-nc May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion lib/Controller/ExAppProxyController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,9 +317,20 @@ private function buildMultipartFormData(array $bodyParams, array $files): array
}

private function passesExAppProxyRoutesChecks(ExApp $exApp, string $exAppRoute): array {
// Route URL is a regex matched against the request path including its leading slash, mirroring HaRP's target_path semantics.
$canonicalSubject = '/' . $exAppRoute;
foreach ($exApp->getRoutes() as $route) {
$pattern = '~^(?:' . str_replace('~', '\\~', $route['url']) . ')~i';
if (preg_match($pattern, $exAppRoute) === 1
$matched = preg_match($pattern, $canonicalSubject) === 1;
if (!$matched && preg_match($pattern, $exAppRoute) === 1) {
// TODO(deprecation): remove this bare-path fallback once known ExApps have migrated their info.xml route URLs to the canonical `^/path$` form. Tracked by the AppAPI / context_chat_backend coordination effort.
$this->logger->debug(sprintf(
'ExApp "%s" matched route "%s" via legacy bare-path fallback. Update the info.xml route URL to start with "/" or "^/" so it matches against "%s".',
$exApp->getAppid(), $route['url'], $canonicalSubject
));
$matched = true;
}
if ($matched
&& str_contains(strtolower($route['verb']), strtolower($this->request->getMethod()))
) {
// First match by path+verb wins. Apply its access level without falling through to broader routes.
Expand Down
Loading