fix(user): update default value of subscribe_to_news in database#1761
Merged
Conversation
Signed-off-by: Edward Ly <contact@edward.ly>
edward-ly
force-pushed
the
fix/noid/subscribe-to-news-default
branch
from
a03addc to
ac914dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After changing the default value of
subscribe_to_newsin theUserProfilemodel in #1524, a database migration should have been created (viapython manage.py makemigrations) and applied to reflect this. This is now resolved. It's not exactly clear to me if the intention was to only apply this to GitHub users or if it should be applied to all users, though, but I imagine it should be opt-in for everyone.The actual migration (to be run later) is done via
python manage.py migrate.