Skip to content

Feat: lazy loading appconfigs#478

Merged
janepie merged 1 commit intomainfrom
feat/lazyload
Feb 26, 2026
Merged

Feat: lazy loading appconfigs#478
janepie merged 1 commit intomainfrom
feat/lazyload

Conversation

@janepie
Copy link
Member

@janepie janepie commented Feb 25, 2026

No description provided.

Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
continue;
}
$value = $this->appConfig->getAppValueString($key);
$this->appConfig->setAppValueString($key, $value, lazy: true);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you double check whether we need to delete the entry first for the lazy-setting to work?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended for me, I don't know if there could be differences between db systems but it's just another column in the db entry so I wouldn't know why it shouldn't

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@janepie janepie merged commit 11c0f60 into main Feb 26, 2026
16 checks passed
@janepie janepie deleted the feat/lazyload branch February 26, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants