fix(l10n): Use "teams" instead of the old "circles"#514
Merged
marcelklehr merged 1 commit intomainfrom Apr 27, 2026
Merged
Conversation
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
rakekniven
reviewed
Apr 27, 2026
| ) { | ||
| $this->informationSources = [ | ||
| 'add_card' => $this->l10n->t('Nextcloud Deck'), | ||
| 'add_member_to_circle' => $this->l10n->t('Add member to circle'), |
Member
There was a problem hiding this comment.
@marcelklehr Are you sure about all changes for given file?
You replaced multiple miscallenous strings with "Nextcloud Teams"
Member
Author
There was a problem hiding this comment.
Yes, it's the cleaner way to reference the tool, as we show these as "sources". "Add member to circle" is not really semantically a source.
rakekniven
approved these changes
Apr 27, 2026
Member
|
@marcelklehr Backports needed to get rid of the "circle" strings at Tx? |
Member
Author
|
Indeed, we have a stable32 branch |
Member
Author
|
/backport to stable32 |
|
The backport to # Switch to the target branch and update it
git checkout stable32
git pull origin stable32
# Create the new backport branch
git checkout -b backport/514/stable32
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick a9239e82
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/514/stable32Error: Failed to check for changes with origin/stable32: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Member
Author
|
/backport to stable32 |
3 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.