feat(Assignments) by marcelklehr · Pull Request #522 · nextcloud/assistant

marcelklehr · 2026-05-05T08:31:36Z

Todo:

Use the assignment tools in nextcloud/context_agent#162 to schedule assignments from the UI, or use curl :)

some stuff still missing Signed-off-by: Marcel Klehr <mklehr@gmx.net>

Move business logic from CHattyLLMController to ChatServiec Signed-off-by: Marcel Klehr <mklehr@gmx.net>

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

Copilot

Pull request overview

This PR introduces an “Assignments” backend for the Assistant app and refactors the existing chat controller by moving business logic into a dedicated ChatService. It adds persistence (DB + migration), an OCS API for CRUD operations, and a background job to execute recurring assignments using RRULEs.

Changes:

Refactor: extract chat/session/message/task scheduling logic from ChattyLLMController into lib/Service/ChatService.php.
Feature: add Assignments domain (DB entity + mapper, OCS controller, service layer, OpenAPI schema) plus RRULE-based “due” evaluation.
Operations: add a timed background job to run due assignments per user; add simshaun/recurr dependency.

Reviewed changes

Copilot reviewed 22 out of 23 changed files in this pull request and generated 15 comments.

Show a summary per file

File	Description
tests/psalm-baseline.xml	Adds Psalm baseline suppressions for `logger('assistant')` usage in the new Assignment entity.
openapi.json	Adds `Assignment` schema and CRUD-ish assignment endpoints under `/ocs/v2.php/apps/assistant/assignments`.
lib/Service/UnauthorizedException.php	New service-layer exception type for auth failures.
lib/Service/NotFoundException.php	New service-layer exception type for missing resources.
lib/Service/InternalException.php	New service-layer exception type for internal failures.
lib/Service/BadRequestException.php	New service-layer exception type for validation/user input issues.
lib/Service/ChatService.php	New service encapsulating chat session/message logic and task scheduling.
lib/Service/AssignmentsService.php	Implements assignment creation and due-run scheduling (including chat session linkage).
lib/ResponseDefinitions.php	Adds Psalm type `AssistantAssignment` used for response typing/OpenAPI extraction.
lib/Migration/Version030500Date20260430083738.php	Creates `assistant_assignments` table and adds `assignment_id` column/index to chat sessions.
lib/Listener/ChattyLLMTaskListener.php	Uses new `Message::ROLE_ASSISTANT` constant instead of raw string.
lib/Db/ChattyLLM/SessionMapper.php	Adds `getUserSessionForAssignment()` lookup by `assignment_id`.
lib/Db/ChattyLLM/Session.php	Adds `assignmentId` field and serializes `assignment_id`.
lib/Db/ChattyLLM/MessageMapper.php	Uses `Message::ROLE_HUMAN` constant; updates return typing docblock.
lib/Db/ChattyLLM/Message.php	Introduces `ROLE_HUMAN` / `ROLE_ASSISTANT` constants.
lib/Db/AssignmentMapper.php	New mapper to load assignments and enumerate due assignments.
lib/Db/Assignment.php	New Assignment entity with RRULE validation and “due to run” logic.
lib/Controller/ChattyLLMController.php	Refactors controller to delegate to `ChatService` and map service exceptions to HTTP responses.
lib/Controller/AssignmentsApiController.php	New OCS controller implementing assignment endpoints.
lib/BackgroundJob/RunAssignmentsJob.php	New timed background job to run due assignments for a user.
composer.lock	Locks new dependencies pulled in by RRULE library.
composer.json	Adds `simshaun/recurr` dependency.
appinfo/info.xml	Bumps app version to `3.5.0-dev.1`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

julien-nc

🐘

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Marcel Klehr <mklehr@gmx.net>

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

Copilot

Pull request overview

Copilot reviewed 23 out of 24 changed files in this pull request and generated 23 comments.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Marcel Klehr <mklehr@gmx.net>

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

Copilot

Pull request overview

Copilot reviewed 23 out of 24 changed files in this pull request and generated 8 comments.

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

Copilot

Pull request overview

Copilot reviewed 23 out of 24 changed files in this pull request and generated 11 comments.

+	public function createUserAssignment(string $prompt, int $startsAt, string $recurrence): DataResponse {
+		try {
+			$assignment = $this->assignmentsService->createAssignment($this->userId, $prompt, $startsAt, $recurrence);
+			$serializedAssignment = $assignment->jsonSerialize();
+			return new DataResponse(['assignment' => $serializedAssignment]);


+			} catch (Exception $e) {
+				$this->logger->error('Error while fetching assignment for user ' . $this->userId, ['exception' => $e]);
+				return new DataResponse('', Http::STATUS_FORBIDDEN);
+			} catch (DoesNotExistException|MultipleObjectsReturnedException) {


+			} catch (Exception $e) {
+				$this->logger->error('Error while fetching assignment for user ' . $this->userId, ['exception' => $e]);
+				return new DataResponse('', Http::STATUS_FORBIDDEN);


+		$session = $this->chatService->createChatSession($userId, $this->timeFactory->now()->getTimestamp(), 'Assignment ' . $assignment->getId()); // TODO: Add a proper title here
+		$session->setAssignmentId($assignment->getId());
+		try {
+			$this->sessionMapper->update($session);
+		} catch (Exception $e) {


+		$assignment->setPrompt($prompt);
+		$assignment->setStartsAt($startsAt);
+		$assignment->setLastRunAt(0);


+		if ($user === null) {
+			throw new UnauthorizedException($this->l10n->t('User not found'));
+		}
+


+	public function getSessionMessages(?string $userId, int $sessionId, $limit = 20, int $cursor = 0): array {
+		if ($userId === null) {
+			throw new UnauthorizedException($this->l10n->t('Unauthorized'));
+		}
+


+				$history = array_map(static function (Message $message) {
+					return json_encode([
+						'role' => $message->getRole(),
+						'content' => $message->getContent(),
+					]);
+				}, $history);


+			/** @var list<AssistantChatSession> $sessions */
+			$sessions = $this->chatService->getSessionsForUser($this->userId);
 			return new JSONResponse($sessions);


+			logger('assistant')->debug('Next recurrence of assignment ' . $this->getId() . ' of user ' . $this->getUserId() . ': ' . $nextRecurrence->getStart()->format('Y-m-d H:i:s') . ' - isDue: ' . ($isDue ? 'true' : 'false'));
+			return $isDue;
+		} catch (InvalidRRule|\Exception|NotFoundExceptionInterface|ContainerExceptionInterface $e) {
+			// this should not happen, as we validate the rule on setRecurrence, but just in case, we catch the exception and log it
+			logger('assistant')->error($e->getMessage(), ['exception' => $e]);


marcelklehr requested review from janepie and julien-nc as code owners May 5, 2026 09:50

marcelklehr added 6 commits May 5, 2026 12:58

feat(Assignments): First pass

a644bef

some stuff still missing Signed-off-by: Marcel Klehr <mklehr@gmx.net>

refactor: Introduce ChatService

76bc21d

Move business logic from CHattyLLMController to ChatServiec Signed-off-by: Marcel Klehr <mklehr@gmx.net>

feat(Assignments): Implement creating and running assignments

f62c60a

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

feat(Assignments): Implement recurrence rule checking

882d471

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

fix(Assignments): Minor fixes to get things to run

71bf6f9

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

fix(Assignments): Minor fixes to get things to run

046cdac

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

marcelklehr force-pushed the feat/assignments branch from efc9c06 to 046cdac Compare May 5, 2026 10:59

marcelklehr added 2 commits May 5, 2026 13:00

fix(Assignments): Minor fixes to get things to run

66c47d7

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

fix(Assignments): Minor fixes to get things to run

dec32dc

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

marcelklehr force-pushed the feat/assignments branch from ce836de to dec32dc Compare May 5, 2026 11:29

marcelklehr added 5 commits May 6, 2026 10:34

fix(Assignments): Set RunAssignmentsJob to 10min

cf1af7f

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

fix: Run cs:fix

2f5c288

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

fix: Fix psalm issues

1860b0e

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

fix: Fix openapi spec

3752b4d

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

fix: Fix REUSE compliance

4c9a7ea

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

marcelklehr mentioned this pull request May 6, 2026

feat(assignments): Add assignments tools nextcloud/context_agent#162

Open

marcelklehr requested a review from Copilot May 6, 2026 13:45

Copilot started reviewing on behalf of marcelklehr May 6, 2026 13:49 View session

Copilot AI reviewed May 6, 2026

View reviewed changes

julien-nc requested changes May 6, 2026

View reviewed changes

Comment thread lib/Migration/Version030500Date20260430083738.php Outdated

Comment thread lib/Migration/Version030500Date20260430083738.php

Comment thread lib/Service/ChatService.php Outdated

Comment thread lib/Service/ChatService.php Outdated

marcelklehr and others added 2 commits May 7, 2026 07:37

Apply suggestions from code review

dea9faf

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Marcel Klehr <mklehr@gmx.net>

fix: Address review comments

c044d78

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

marcelklehr requested review from Copilot and julien-nc May 7, 2026 05:53

Copilot started reviewing on behalf of marcelklehr May 7, 2026 05:55 View session

marcelklehr added 2 commits May 7, 2026 07:55

fix: Address review comments

04c77fa

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

fix: Regenerate openapi spec

e993dbb

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

Copilot AI reviewed May 7, 2026

View reviewed changes

marcelklehr and others added 4 commits May 7, 2026 08:36

Fix: Address review comment

5a1bfe3

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Marcel Klehr <mklehr@gmx.net>

Fix: Address review comment

109fb62

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Marcel Klehr <mklehr@gmx.net>

Apply suggestions from code review

0e8ea5d

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Marcel Klehr <mklehr@gmx.net>

fix: Address review comments

48d4c82

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

marcelklehr requested a review from Copilot May 7, 2026 06:47

Copilot started reviewing on behalf of marcelklehr May 7, 2026 06:48 View session

Copilot AI reviewed May 7, 2026

View reviewed changes

fix: Address review comments

e483ae2

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

marcelklehr requested a review from Copilot May 7, 2026 09:23

Copilot started reviewing on behalf of marcelklehr May 7, 2026 09:25 View session

Copilot AI reviewed May 7, 2026

View reviewed changes

Conversation

marcelklehr commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

julien-nc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

marcelklehr commented May 5, 2026 •

edited

Loading