Skip to content

Fix: title height#524

Merged
janepie merged 4 commits intomainfrom
fix/title-ui-issues
May 7, 2026
Merged

Fix: title height#524
janepie merged 4 commits intomainfrom
fix/title-ui-issues

Conversation

@janepie
Copy link
Copy Markdown
Member

@janepie janepie commented May 6, 2026

Is fixed to the header height now and scrolls when the title doesn't fit

image

Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
@janepie janepie requested review from julien-nc and marcelklehr May 6, 2026 15:26
@julien-nc
Copy link
Copy Markdown
Member

julien-nc commented May 6, 2026

With this branch

image

With the main branch

image

Weird... For short titles, main looks more correct.

@janepie
Copy link
Copy Markdown
Member Author

janepie commented May 6, 2026

What do you mean? Your title is too short

@janepie
Copy link
Copy Markdown
Member Author

janepie commented May 6, 2026

Or do you mean the height of the line?

@julien-nc
Copy link
Copy Markdown
Member

Yes height of the line with a short title.

@julien-nc
Copy link
Copy Markdown
Member

julien-nc commented May 6, 2026

And with a long title it scrolls vertically. I think horizontally is better. Wdyt?
Or even Ellipsis and add an HTML title (with the session title as value).

janepie added 2 commits May 6, 2026 17:47
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
@janepie
Copy link
Copy Markdown
Member Author

janepie commented May 6, 2026

Better?

Screencast above

@marcelklehr
Copy link
Copy Markdown
Member

Ellipsis and add an HTML title is the way to go, imho

@janepie
Copy link
Copy Markdown
Member Author

janepie commented May 6, 2026

Not sure what you mean by "add an HTML title"

@marcelklehr
Copy link
Copy Markdown
Member

Add an html title attribute with the full text, as it will be cut off by the ellipsis.

Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
@janepie
Copy link
Copy Markdown
Member Author

janepie commented May 7, 2026

Done!

Copy link
Copy Markdown
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@janepie janepie merged commit 962c3bd into main May 7, 2026
9 checks passed
@janepie janepie deleted the fix/title-ui-issues branch May 7, 2026 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants