Fix bugs, clean up code, and restore fire-and-forget reactions

[Copilot]

Several real bugs found and fixed across the codebase, plus a design clarification: reactions should be non-blocking background operations, not part of the critical path.

Bugs fixed

• pushBranch race condition — git.remote(['set-url', ...]) was not awaited; the authenticated URL could be set after the push already ran
• Commit message amendment lost subject line (cherryPickCommits) — only body was used when reconstructing the amended message, dropping the subject line entirely; commits with no body silently skipped adding [skip ci]
• Wrong todo step for diff-only warning (getBackportBody) — pushed STEP_REVIEW_CONFLICTS even when there were no conflicts, only a diff; added STEP_REVIEW_CHANGES constant for this case
• error(task, e) type mismatch in queue.ts — passed an Error object to a string-typed parameter
• Stray console.trace() in production failure handler
• Log message typo — ${commentAuthor}} had an extra }
• Extra leading space in warning body text ("\n\n Warning," → "\n\nWarning,")
• Variable shadowing — local hasEmptyCommits variable inside the hasEmptyCommits function

Reactions: fire-and-forget via .catch()

Reactions were originally unawaited (intentionally non-blocking), but that made surrounding try/catch blocks dead code. Adding await fixed the error handling but made reactions block the backport process — wrong trade-off.

The correct pattern: fire-and-forget with .catch() for error logging.

// Before (blocking):
try {
    await addReaction(octokit, task, Reaction.THUMBS_UP)
} catch (e) {
    error(task, `Failed to add reaction: ${e.message}`)
}

// After (non-blocking, errors still logged):
addReaction(octokit, task, Reaction.THUMBS_UP)
    .catch(err => error(task, `Failed to add reaction: ${err.message}`))

All addReaction call sites in index.ts and backport.ts updated. Standalone try/catch blocks that existed solely for a single reaction, and a now-dead try/catch around the synchronous isFriendly() call, are removed. In the failure handler, the THUMBS_DOWN reaction is fire-and-forget while commentOnPR remains awaited.

---

📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

[codecov]

Codecov Report

❌ Patch coverage is 61.53846% with 25 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/gitUtils.ts	0.00%	10 Missing ⚠️
src/index.ts	0.00%	8 Missing ⚠️
src/backport.ts	0.00%	4 Missing ⚠️
src/nextcloudUtils.spec.ts	94.87%	0 Missing and 2 partials ⚠️
src/queue.ts	0.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!