Skip to content

fix: #663 error in cron.php since NC 29 #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
artonge merged 4 commits into from
Jan 21, 2025
Merged

fix: #663 error in cron.php since NC 29 #725

artonge merged 4 commits into from
Jan 21, 2025

Conversation

@smarinier
Copy link
Contributor

@smarinier smarinier commented Oct 9, 2024

  • TimedJob is now OCP, and requires a time
  • add modern properties assignment in constructors ---

Fix #663

@smarinier
fix: nextcloud#663 error in cron.php since NC 29
3a4a3fe 
---
- TimedJob is now OCP, and requires a time
- add modern properties assignment in constructors
---

Signed-off-by: Sebastien Marinier <seb@smarinier.net>
@smarinier smarinier mentioned this pull request Oct 9, 2024
Open
@github-actions
Copy link

github-actions bot commented Oct 24, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@Tampa
Copy link

Tampa commented Jan 20, 2025

Is someone even active on here? How is this still open? Backups are vital to data security and integrity, the key points nextcloud is trying to make.

@smarinier
Copy link
Contributor Author

smarinier commented Jan 21, 2025 •
edited
Loading

Hi @ArtificialOwl , @artonge . Could you have a look on this ? Thanks

artonge
artonge approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks :)

@artonge artonge merged commit 0a68ee8 into nextcloud:master Jan 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge approved these changes

Assignees

No one assigned

Labels

feedback-requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error in cron.php since Nextcloud Version 29

3 participants

@smarinier @Tampa @artonge