Skip to content

fix issue with three part timezone names like America/Argentina/Buenos_Aires #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tcitworld merged 3 commits into from
Mar 21, 2017
Merged

fix issue with three part timezone names like America/Argentina/Buenos_Aires #361

tcitworld merged 3 commits into from
Mar 21, 2017

Conversation

@georgehrke
Copy link
Member

@georgehrke georgehrke commented Mar 10, 2017 •
edited
Loading

please review @tcitworld @nextcloud/calendar

fixes #358

subRegion didn't match with the subregion from routes.php -> rename to subregion

@georgehrke georgehrke added the 3. to review Waiting for reviews label Mar 10, 2017
@georgehrke georgehrke requested a review from tcitworld March 10, 2017 17:40
@georgehrke georgehrke force-pushed the bugfix/358/three_part_timezone_name branch from c800215 to 73de1cc Compare March 11, 2017 08:47
@georgehrke georgehrke added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Mar 11, 2017
@georgehrke georgehrke force-pushed the bugfix/358/three_part_timezone_name branch from 73de1cc to 6eafe27 Compare March 12, 2017 17:03
@georgehrke
fix issue with three part timezone names like America/Argentina/Bueno…
66ff009 
…s_Aires

Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke georgehrke force-pushed the bugfix/358/three_part_timezone_name branch from 6eafe27 to 66ff009 Compare March 16, 2017 11:50
@georgehrke
store timezone promise for the time its not resolved yet
78afa39 
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke georgehrke added 3. to review Waiting for reviews 2. developing Work in progress and removed 2. developing Work in progress 3. to review Waiting for reviews labels Mar 16, 2017
@georgehrke
fix fallback to UTC when using unknown timezone
9b767b9 
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke georgehrke force-pushed the bugfix/358/three_part_timezone_name branch from fdaf2d1 to 9b767b9 Compare March 16, 2017 17:31
@georgehrke georgehrke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 16, 2017
@georgehrke
Copy link
Member Author

georgehrke commented Mar 16, 2017 •
edited
Loading

@tcitworld I added some more changes :)

Can you please review again? :)

@georgehrke georgehrke added this to the 1.5.2 milestone Mar 18, 2017
fauust
fauust approved these changes Mar 21, 2017
View reviewed changes
Copy link

@fauust fauust left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok works again.
Some precision: I have just applied the commit 66ff009

@georgehrke
Copy link
Member Author

georgehrke commented Mar 21, 2017

@tcitworld Can you please review this again? :)

This bug is a rather serious regression and I would like to release 1.5.2 :)

@tcitworld
Copy link
Member

tcitworld commented Mar 21, 2017

Looks good.

@tcitworld tcitworld merged commit 9ddb909 into master Mar 21, 2017
@tcitworld tcitworld deleted the bugfix/358/three_part_timezone_name branch March 21, 2017 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tcitworld tcitworld tcitworld approved these changes

+1 more reviewer

@fauust fauust fauust approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3. to review Waiting for reviews priority

Projects

None yet

Milestone

1.5.2-current-patch

Development

Successfully merging this pull request may close these issues.

unknown timezone (America/Argentina/Buenos_Aires) back to UTC

4 participants

@georgehrke @tcitworld @fauust