use closure for adding navigation entry #369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
|
@georgehrke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tcitworld and @jancborchardt to be potential reviewers. |
Member
Author
|
The closure thing is supported all the way back to Nextcloud 9: As the documentation explicitly states that closure is the preferred way I'd still like to merge this even though it doesn't fix #368 |
tcitworld
approved these changes
Mar 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please review @bastoGrande @tcitworld @nextcloud/calendar
fixes #368