Optimize info.xml for App Store #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marius Blüm <marius@lineone.io>
|
@MariusBluem, thanks for your PR! By analyzing the history of the files in this pull request, we identified @georgehrke, @tcitworld and @ChristophWurst to be potential reviewers. |
Member
|
Isn't the lack of |
Member
Author
|
Thought it makes no difference here, because we are not using |
tcitworld
requested changes
Mar 23, 2017
appinfo/info.xml
Outdated
| * 🙋 **Attendees!** Invite people to your events. | ||
| * 🙈 **We’re not reinventing the wheel!** Based on the great [davclient.js](https://github.com/evert/davclient.js), [ical.js](https://github.com/mozilla-comm/ical.js) and [fullcalendar](https://github.com/fullcalendar/fullcalendar) libraries. | ||
| ]]</description> |
Member
There was a problem hiding this comment.
You're missing a > here, it should be ]]></description>.
Signed-off-by: Marius Blüm <marius@lineone.io>
georgehrke
approved these changes
Mar 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marius Blüm marius@lineone.io