Skip to content

Conversation

@Dennis1993
Copy link
Contributor

@Dennis1993 Dennis1993 commented Apr 23, 2017

fixes #314
The left sidebar from NextCloud use a right border in #ebebeb (grey). The grid use the color #f8f8f8 (darker grey). I changed the color to #ebebeb to improve the visibility. Maybe this is a little bit better to see the borders.

Before:
before

After:
after

idea to #314
The left sidebar from NextCloud uses a right border in #ebebeb. The grid use the color #f8f8f8. I chanced the color to #ebebeb (a Little bit darker) to improve the visibility.
@mention-bot
Copy link

@Dennis1993, thanks for your PR! By analyzing the history of the files in this pull request, we identified @raghunayyar, @tcitworld and @georgehrke to be potential reviewers.

@georgehrke
Copy link
Member

Thanks for your PR! :)

But I'm not sure about this change.
If anything, we wanted to change the vertical border-color, not the border-color of the entire grid.

@georgehrke
Copy link
Member

cc @jancborchardt

@Dennis1993 Dennis1993 added the design Related to design, interface, interaction design, UX, etc. label Apr 23, 2017
@jancborchardt
Copy link
Member

Yeah, agree with Georg. This is a bit too dark and instantly makes the Calendar a bit dated. A slight enhancement might be all that's needed, maybe only making the header text a bit darker if anything?

@georgehrke
Copy link
Member

What about just overwriting border-left-color and border-right-color?

@Dennis1993
Copy link
Contributor Author

Okay, I agree with you! :) That's true.

Thanks for your feedback!

@georgehrke
Copy link
Member

@Dennis1993 Can you please use border-color-left and border-color-right? :)

Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke georgehrke added the 3. to review Waiting for reviews label Apr 29, 2017
@georgehrke
Copy link
Member

fixed the border-color-left border-color-right thing, will merge if travis is happy

@jancborchardt
Copy link
Member

Can you post a quick before / after screenshot?

@georgehrke
Copy link
Member

Here you go :)
Before:
master-month
master-week

After:
patch-month
patch-week

@georgehrke
Copy link
Member

@jancborchardt please hit merge if you are happy :)

@georgehrke
Copy link
Member

ping @jancborchardt

@georgehrke georgehrke merged commit 322dc26 into master May 12, 2017
@georgehrke georgehrke deleted the Dennis1993-patch-1 branch May 12, 2017 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews design Related to design, interface, interaction design, UX, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vertical bars are almost invisible in week view

6 participants