Skip to content

Comments

style: add a gap for event dragging#6775

Merged
GVodyanov merged 1 commit intomainfrom
style/gap-grid-dragging
Mar 31, 2025
Merged

style: add a gap for event dragging#6775
GVodyanov merged 1 commit intomainfrom
style/gap-grid-dragging

Conversation

@GVodyanov
Copy link
Contributor

Fix #6424

Before After
image image

@GVodyanov GVodyanov added the 3. to review Waiting for reviews label Feb 28, 2025
@GVodyanov GVodyanov self-assigned this Feb 28, 2025
@codecov
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.91%. Comparing base (0fb2f7a) to head (4cf192d).
Report is 54 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6775      +/-   ##
============================================
- Coverage     23.01%   22.91%   -0.10%     
  Complexity      476      476              
============================================
  Files           252      252              
  Lines         12216    12287      +71     
  Branches       2353     2369      +16     
============================================
+ Hits           2811     2816       +5     
- Misses         9066     9127      +61     
- Partials        339      344       +5     
Flag Coverage Δ
javascript 14.56% <ø> (-0.06%) ⬇️
php 59.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ChristophWurst
Copy link
Member

Let's have the gap only on the right. That seems to be the standard in Gnome Evolution, Google Calendar and Outlook.

@GVodyanov GVodyanov force-pushed the style/gap-grid-dragging branch from 803b8c5 to 318cbad Compare March 10, 2025 16:23
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

Just to not confuse the release automation: please change the commit message from type style to fix. Style is meant for coding style changes only.

The release automation will otherwise hide this change from the changelog.

Ref https://github.com/angular/angular/blob/22b96b9/CONTRIBUTING.md#type

@ChristophWurst
Copy link
Member

🏓 @GVodyanov this seems ready except for the conventional commit message

@ChristophWurst
Copy link
Member

/backport to stable5.2

@backportbot backportbot bot added the backport-request A backport was requested for this pull request label Mar 31, 2025
Signed-off-by: Grigory Vodyanov <scratchx@gmx.com>
@GVodyanov GVodyanov force-pushed the style/gap-grid-dragging branch from 318cbad to 4cf192d Compare March 31, 2025 14:44
@GVodyanov GVodyanov merged commit 68a93a5 into main Mar 31, 2025
47 of 48 checks passed
@GVodyanov GVodyanov deleted the style/gap-grid-dragging branch March 31, 2025 14:47
@backportbot backportbot bot removed the backport-request A backport was requested for this pull request label Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

there should be space/gap next to events, so you can create new events at the same time as existing events

2 participants