Skip to content

Comments

fix(editor): Allow edits as attending organizer#6809

Merged
ChristophWurst merged 1 commit intomainfrom
fix/editor/attending-organizer
Mar 31, 2025
Merged

fix(editor): Allow edits as attending organizer#6809
ChristophWurst merged 1 commit intomainfrom
fix/editor/attending-organizer

Conversation

@ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Mar 13, 2025

#6778 hid actions that attendees shouldn't execute. However, there can be ORGANIZERs that are also listed as ATTENDEE. Don't ask me how, it happens. Then we hide the actions also from the actual organizer.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews bug Feature: Editor regression Regression of a previous working feature labels Mar 13, 2025
@ChristophWurst ChristophWurst requested a review from hamza221 March 13, 2025 09:31
@ChristophWurst ChristophWurst self-assigned this Mar 13, 2025
@ChristophWurst
Copy link
Member Author

/backport to stable5.2 please

@ChristophWurst
Copy link
Member Author

/backport to stable5.1 please

@backportbot backportbot bot added the backport-request A backport was requested for this pull request label Mar 13, 2025
@codecov
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 28.72%. Comparing base (0fb2f7a) to head (ba6dea5).
Report is 52 commits behind head on main.

Files with missing lines Patch % Lines
src/mixins/EditorMixin.js 0.00% 5 Missing and 1 partial ⚠️
src/views/EditSidebar.vue 0.00% 4 Missing ⚠️
src/views/EditSimple.vue 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6809      +/-   ##
============================================
+ Coverage     23.01%   28.72%   +5.71%     
- Complexity      476      952     +476     
============================================
  Files           252      294      +42     
  Lines         12216    14518    +2302     
  Branches       2353     2358       +5     
============================================
+ Hits           2811     4171    +1360     
- Misses         9066    10007     +941     
- Partials        339      340       +1     
Flag Coverage Δ
javascript 14.60% <0.00%> (-0.02%) ⬇️
php 59.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hamza221
Copy link
Contributor

hamza221 commented Mar 13, 2025

Don't ask me how, it happens

Maybe it's Happening when Inviting a circle? The organizer is also getting invited if he's part of the circle ?

@ChristophWurst
Copy link
Member Author

Nope, I have tested that scenario. It seems we filter the organizer out already for circles

@hamza221
Copy link
Contributor

Not sure how to reproduce See decline button and Attendee tab
image
Ics

ATTENDEE;CN=admin;CUTYPE=INDIVIDUAL;PARTSTAT=ACCEPTED:mailto:admin@example.net
ORGANIZER;CN=admin:mailto:admin@example.net

@ChristophWurst
Copy link
Member Author

What is the issue there?

@ChristophWurst ChristophWurst merged commit 164106a into main Mar 31, 2025
46 of 47 checks passed
@ChristophWurst ChristophWurst deleted the fix/editor/attending-organizer branch March 31, 2025 13:52
@backportbot backportbot bot removed the backport-request A backport was requested for this pull request label Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Feature: Editor regression Regression of a previous working feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants