Skip to content

Conversation

@SebastianKrupinski
Copy link
Contributor

@SebastianKrupinski SebastianKrupinski commented Mar 13, 2025

Resolves: the inability to select a day for a year occurrence. Try creating a event for a anniversary that happens on July 1st every year

image

@codecov
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

Attention: Patch coverage is 18.18182% with 54 lines in your changes missing coverage. Please review.

Project coverage is 22.95%. Comparing base (43fb124) to head (49f98be).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/store/calendarObjectInstance.js 0.00% 23 Missing and 1 partial ⚠️
...mponents/Editor/Repeat/RepeatFreqYearlyOptions.vue 0.00% 18 Missing ⚠️
src/models/recurrenceRule.js 52.94% 6 Missing and 2 partials ⚠️
src/components/Editor/Repeat/Repeat.vue 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6817      +/-   ##
============================================
- Coverage     22.98%   22.95%   -0.03%     
  Complexity      476      476              
============================================
  Files           252      252              
  Lines         12212    12266      +54     
  Branches       2353     2362       +9     
============================================
+ Hits           2807     2816       +9     
- Misses         9066     9108      +42     
- Partials        339      342       +3     
Flag Coverage Δ
javascript 14.59% <18.18%> (+0.01%) ⬆️
php 59.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SebastianKrupinski SebastianKrupinski force-pushed the fix/noid/fix-yearly-recurrance-options-part-2 branch from 174426c to b2a431f Compare March 15, 2025 12:58
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
Signed-off-by: Grigory Vodyanov <scratchx@gmx.com>
@SebastianKrupinski SebastianKrupinski force-pushed the fix/noid/fix-yearly-recurrance-options-part-2 branch from 9581981 to 49f98be Compare March 15, 2025 14:26
@SebastianKrupinski
Copy link
Contributor Author

/backport to stable5.2

@backportbot backportbot bot added the backport-request A backport was requested for this pull request label Mar 15, 2025
@SebastianKrupinski
Copy link
Contributor Author

/backport to stable5.1

@SebastianKrupinski SebastianKrupinski merged commit c2050ba into main Mar 15, 2025
46 of 48 checks passed
@SebastianKrupinski SebastianKrupinski deleted the fix/noid/fix-yearly-recurrance-options-part-2 branch March 15, 2025 14:30
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware team Mar 15, 2025
@backportbot backportbot bot removed the backport-request A backport was requested for this pull request label Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

Development

Successfully merging this pull request may close these issues.

3 participants